Fix the bug that the grpc protocol is incompatible with authentication(issue:#3001)#3002
Merged
Conversation
Contributor
Author
|
Close #3001 |
Paragrf
changed the title
Paragrf
force-pushed
the
fix_grpc_auth
branch
2 times, most recently
from
97390dc to
71e7937
Compare
…y could not be parsed by the client to get the correct error code after authentication failed
Paragrf
changed the title
Contributor
Author
|
@chenBright please take a look ：） |
Contributor
|
Please add unit test for this case in test/brpc_server_unittest.cpp. |
Contributor
Author
@chenBright done |
Contributor
Author
|
@chenBright @wwbmmm please take a look， thx |
chenBright
reviewed
Jun 28, 2025
Contributor
Author
|
@chenBright hello, can this PR be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y could not be parsed by the client to get the correct error code after authentication failed
What problem does this PR solve?
Issue Number: #3001
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: