Skip to content

Limit redis alloc size#3050

Merged
wwbmmm merged 3 commits into
apache:masterfrom
wwbmmm:limit-redis-alloc-size
Aug 2, 2025
Merged

Limit redis alloc size#3050
wwbmmm merged 3 commits into
apache:masterfrom
wwbmmm:limit-redis-alloc-size

Conversation

@wwbmmm

@wwbmmm wwbmmm commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: null

Problem Summary: redis request or response may have a too large size that cause the server to consume too much memory.

What is changed and the side effects?

Changed: Add a limit for allocation size

Side effects:

  • Performance effects: no

  • Breaking backward compatibility: Some redis request/response may fail to parse if the data size exceed the default value of redis_max_allocation_size (64M). User can adjust the flag redis_max_allocation_size for their senarios.


Check List:

@wwbmmm wwbmmm requested a review from Copilot July 31, 2025 02:31

This comment was marked as resolved.

@wwbmmm wwbmmm requested a review from chenBright July 31, 2025 03:09
@apache apache deleted a comment from Copilot AI Jul 31, 2025
@apache apache deleted a comment from Copilot AI Jul 31, 2025

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwbmmm wwbmmm merged commit 0e5d022 into apache:master Aug 2, 2025
15 checks passed
wwbmmm added a commit that referenced this pull request Aug 2, 2025
* Reapply "Add redis allocation size limit (#3035)"

This reverts commit d0f8f8f.

* Fix int overflow

* Update log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants