Limit the extra options of jemalloc profiler#3101
Merged
Merged
Conversation
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation for the extra_options query parameter in the jemalloc profiler to prevent arbitrary command injection. It ensures only valid jemalloc profiler options are accepted and refactors string concatenation to use safer string formatting functions.
- Introduces a whitelist of valid extra options for jemalloc profiler
- Adds validation to only accept predefined extra options
- Refactors string concatenation to use
butil::string_printfandbutil::string_appendf
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
chenBright
added a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Limit the extra options of jemalloc profiler * Add warning log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
Limit the extra options of jemalloc profiler to one of inuse_space, inuse_objects, alloc_space, alloc_objects, show_bytes, drop_negative, total_delay, contentions or mean_delay.
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: