Fix hanging during SSL_write for large packets#3105
Merged
Conversation
Contributor
|
LGTM |
Contributor
|
Is BIO_flush still needed? Lines 934 to 939 in 7229c36 |
Contributor
Author
No. BIO_wpending will return 0, so this code will not be reached. For clarity, I have commented out the code and left a note. |
chenBright
pushed a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
Fix hanging during SSL_write for large packets
chenBright
pushed a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
Fix hanging during SSL_write for large packets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
When sending large packet under SSL, brpc could stuck as data still resides in BIO buffer.
What is changed and the side effects?
Changed: Disable BIO for SSL for 2 reasons:
Side effects:
Performance effects: Should be no impact
Breaking backward compatibility: No
Check List: