You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In RDMA polling mode, all messages must be executed in a new bthread and
not in the bthread where the polling bthread is located, because the
method for processing messages may call synchronization primitives,
causing the polling bthread to be scheduled out.
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List:
Please make sure your changes are compilable.
When providing us with a new feature, it is best to add related tests.
If the method for processing messages don't have synchronization primitives, running in the polling bthread is ok? Will this PR affect performance?
yes,for example the method just change a variable. this just use in rdma polling mode and it is unavoidable. we don't know user's logic.
If the user confirms that synchronization primitives will not be called, set rdma_disable_bthread flag to true, all message process will be run in the polling thread.
summary:
1、in non-polling mode, socket will process in a new bthread(bthread_start_urgent) and last message will process in this bthread, other message will start new bthreads.
2、in polling-mode, socket will process in polling bthread, and all message will start bthreads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
In RDMA polling mode, all messages must be executed in a new bthread and
not in the bthread where the polling bthread is located, because the
method for processing messages may call synchronization primitives,
causing the polling bthread to be scheduled out.
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: