Skip to content

Only store failed SignalSyncs #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenBright merged 1 commit into from
Oct 27, 2025
Merged

Only store failed SignalSyncs #3128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bthread/task_tracer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ TaskTracer::Result TaskTracer::SignalTrace(pthread_t worker_tid) {
return Result::MakeErrorResult("Fail to pthread_sigqueue: %s", berror());
}
}
_inuse_signal_syncs.push_back(signal_sync);

// Wait for the signal handler to complete.
butil::Timer timer;
Expand All @@ -435,13 +434,14 @@ TaskTracer::Result TaskTracer::SignalTrace(pthread_t worker_tid) {
if (EINTR == errno) {
continue;
}
// Extend the lifetime of `signal_sync' to
// avoid it being destroyed in the signal handler.
_inuse_signal_syncs.push_back(signal_sync);
Comment thread
chenBright marked this conversation as resolved.
return Result::MakeErrorResult("Fail to poll: %s", berror());
}
break;
}
// Remove the successful SignalSync.
_inuse_signal_syncs.pop_back();


return signal_sync->result;
}

Expand Down
Loading