Skip to content

feat: support more ssl verify mode #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wwbmmm merged 2 commits into from
Dec 8, 2025
Merged

feat: support more ssl verify mode #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4681854
feat: support more ssl verify mode
Nov 6, 2025
6039671
1
Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/brpc/details/ssl_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@



#include "brpc/ssl_options.h"
#include <openssl/bio.h>
#ifndef USE_MESALINK

Expand Down Expand Up @@ -412,8 +413,18 @@ static int SetSSLOptions(SSL_CTX* ctx, const std::string& ciphers,

// TODO: Verify the CNAME in certificate matches the requesting host
if (verify.verify_depth > 0) {
SSL_CTX_set_verify(ctx, (SSL_VERIFY_PEER
| SSL_VERIFY_FAIL_IF_NO_PEER_CERT), NULL);
if (verify.verify_mode == VerifyMode::VERIFY_FAIL_IF_NO_PEER_CERT) {
SSL_CTX_set_verify(ctx, (SSL_VERIFY_PEER
| SSL_VERIFY_FAIL_IF_NO_PEER_CERT), NULL);
} else if (verify.verify_mode == VerifyMode::VERIFY_PEER) {
SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER, NULL);
} else if (verify.verify_mode == VerifyMode::VERIFY_NONE) {
SSL_CTX_set_verify(ctx, SSL_VERIFY_NONE, NULL);
} else {
// for forward compatibility
SSL_CTX_set_verify(ctx, (SSL_VERIFY_PEER
| SSL_VERIFY_FAIL_IF_NO_PEER_CERT), NULL);
}
SSL_CTX_set_verify_depth(ctx, verify.verify_depth);
std::string cafile = verify.ca_file_path;
if (cafile.empty()) {
Expand Down
5 changes: 4 additions & 1 deletion src/brpc/ssl_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@

namespace brpc {

VerifyOptions::VerifyOptions() : verify_depth(0) {}
VerifyOptions::VerifyOptions()
: verify_depth(0)
, verify_mode(VerifyMode::NOT_SET)
{}

ChannelSSLOptions::ChannelSSLOptions()
: ciphers("DEFAULT")
Expand Down
12 changes: 12 additions & 0 deletions src/brpc/ssl_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ struct CertInfo {
std::vector<std::string> sni_filters;
};

enum class VerifyMode {
NOT_SET,
VERIFY_NONE,
VERIFY_PEER,
VERIFY_FAIL_IF_NO_PEER_CERT,
};

struct VerifyOptions {
// Constructed with default options
VerifyOptions();
Expand All @@ -50,6 +57,11 @@ struct VerifyOptions {
// Default: 0
int verify_depth;

// Set ssl verify mode for openssl
// If VERIFY_FAIL_IF_NO_PEER_CERT, it will set `SSL_VERIFY_FAIL_IF_NO_PEER_CERT | SSL_VERIFY_PEER`
// Default: NOT_SET
VerifyMode verify_mode;

// Set the trusted CA file to verify the peer's certificate
// If empty, use the system default CA files
// Default: ""
Expand Down
Loading