fix: avoid SIGSEGV in read_proc_io during static initialization#3184
Merged
Conversation
Signed-off-by: jiasheng.yu <jiashengyu@deepglint.com>
Contributor
|
LGTM |
zchuango
pushed a commit
to zchuango/brpc
that referenced
this pull request
May 9, 2026
…he#3184) Signed-off-by: jiasheng.yu <jiashengyu@deepglint.com> Co-authored-by: jiasheng.yu <jiashengyu@deepglint.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #3183
Problem Summary:
When /proc/self/io is inaccessible, read_proc_io calls PLOG during global static construction. If glog is not yet initialized, it triggers a SIGSEGV.
What is changed and the side effects?
Changed:
Replace PLOG_ONCE with a guarded fprintf(stderr, ...) to ensure safety during early startup. A static flag is used to maintain the "print once" behavior.
Side effects:
Performance effects: none
Breaking backward compatibility: none
Check List: