Stop using child process for downloading URL's#1771
Closed
nanonyme wants to merge 1 commit into
Closed
Conversation
nanonyme
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
This makes things really hard to debug when there are errors and downloading is mostly done with GIL dropped.
nanonyme
force-pushed
the
blocking-activity
branch
from
97a399f to
fb369db
Compare
Contributor
|
It just crossed my mind that maybe what was meant by "starving the scheduler" isn't actually about the GIL. Can you please try to terminate a fetch during download and see if it works? |
Contributor
Author
|
Good point. Though I don't think termination works right now either. You get a really miserable set of stacktraces which eventually maybe results in stopping. |
Contributor
Author
|
I converted this into draft so won't be accidentally merged before the important question is answered. |
Contributor
Author
|
@abderrahim has better fix for this at #1814 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1766 and #1761 This makes things really hard to debug when there are errors and downloading is mostly done with GIL dropped.