Fix pulling buildtrees in bst shell#1882
Merged
Merged
Conversation
We use _PipelineSelection.NONE when using the buildtrees, which includes the element. But then, we also add the element once more, and end up with two jobs running at once and (sometimes) failing to link the artifacts into place This fixes test_shell_pull_cached_buildtree[pull-without-buildtree] failing randomly
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
gtristan
approved these changes
Dec 5, 2023
gtristan
left a comment
gtristan
left a comment
Contributor
There was a problem hiding this comment.
Awesome ! Nice catch :)
Contributor
Author
|
I see the buildgrid test is failing, but that's likely because of a previous commit that was merged thinking only test_shell_pull_cached_buildtree was failing. Will fix in a follow-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use _PipelineSelection.NONE when using the buildtrees, which includes the element. But then, we also add the element once more, and end up with two jobs running at once and (sometimes) failing to link the artifacts into place
This fixes test_shell_pull_cached_buildtree[pull-without-buildtree] failing randomly