Handle Jetty's removal of method ServletContextHandler.addFilter(String,String,int)#1
Closed
ryfow wants to merge 1 commit into
Closed
Handle Jetty's removal of method ServletContextHandler.addFilter(String,String,int)#1ryfow wants to merge 1 commit into
ryfow wants to merge 1 commit into
Conversation
…ng,String,int) Jetty no longer has this method in 8.x versions. Looking at Jetty's FilterMapping.setDispatcherTypes(), ServletContextHandler.addFilter(String filterClass,String pathSpec,EnumSet<DispatcherType> dispatches) with null for the third parameter appears to do the same thing.
Contributor
|
Can you close this pull requests now that it has been applied to the codebase? |
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Nov 10, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Nov 14, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Dec 3, 2018
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
asfgit
pushed a commit
that referenced
this pull request
Feb 8, 2019
...nging When `maven-shade-plugin` is run under Java 11 it tends to hang in: ``` "main" #1 prio=5 os_prio=0 cpu=1597418.82ms elapsed=3787.04s tid=0x00007fc7ec012000 nid=0x7b24 runnable [0x00007fc7f34ae000] java.lang.Thread.State: RUNNABLE at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(MavenJDOMWriter.java:272) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateExclusion(MavenJDOMWriter.java:488) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateDependency(MavenJDOMWriter.java:1335) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.iterateDependency(MavenJDOMWriter.java:386) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.updateModel(MavenJDOMWriter.java:1623) at org.apache.maven.plugins.shade.pom.MavenJDOMWriter.write(MavenJDOMWriter.java:2156) at org.apache.maven.plugins.shade.pom.PomWriter.write(PomWriter.java:75) at org.apache.maven.plugins.shade.mojo.ShadeMojo.rewriteDependencyReducedPomIfWeHaveReduction(ShadeMojo.java:1049) at org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(ShadeMojo.java:978) at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:538) ``` This removes the generation of dependency reduced POM and skips over the blocking part.
JiriOndrusek
added a commit
to JiriOndrusek/camel
that referenced
this pull request
Jun 14, 2021
iliya-gr
added a commit
to iliya-gr/camel
that referenced
this pull request
Sep 23, 2024
…ed for array type request.
4 tasks
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetty no longer has a ServletContextHandler.addFilter(String,String,int) method in 8.x versions. I looked at Jetty's FilterMapping.setDispatcherTypes() method and it appears to me that, calling ServletContextHandler.addFilter(String,String,EnumSet) with null for the third parameter does the same thing.