CAMEL-23451: skip non-module files in incremental build instead of aborting#23115
Merged
Conversation
Files in directories without a pom.xml (e.g. proposals/*.adoc, README.md) caused findProjectRoot to return "." which the script treated as "root project changed", aborting all test execution. This meant PRs touching any non-module file alongside real code changes would run zero tests. Skip these files and continue processing the remaining changes. Root-level POM changes are already handled by the grep and Scalpel dependency analysis. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
May 11, 2026
squakez
approved these changes
May 11, 2026
Contributor
|
Once merged, please let's close: CAMEL-23451 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-23451
Regression from #22247: when the CI rationalization removed the
buildAllmode, theprojectRoot == "."case was changed from "build everything" toexit 0(skip all tests).This means files in directories without a
pom.xml(e.g.proposals/*.adoc,README.md)cause
findProjectRootto return".", and the script aborts all test execution — evenwhen the PR also contains real code changes.
For example, PR #23002 ran no tests because
it modified
proposals/tracing.adoc.Fix: Skip non-module files with
continueinstead of aborting. Root-level POM changesare already handled separately by the grep and Scalpel dependency analysis in Step 2.
Test plan
proposals/*.adoc→ no modules tested (correct, doc-only)proposals/*.adoc+ component code → component tests run (was broken, now fixed)