Skip to content

CAMEL-23451: skip non-module files in incremental build instead of aborting#23115

Merged
gnodet merged 1 commit into
apache:mainfrom
gnodet:salt-armchair
May 11, 2026
Merged

CAMEL-23451: skip non-module files in incremental build instead of aborting#23115
gnodet merged 1 commit into
apache:mainfrom
gnodet:salt-armchair

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented May 11, 2026

CAMEL-23451

Regression from #22247: when the CI rationalization removed the buildAll mode, the
projectRoot == "." case was changed from "build everything" to exit 0 (skip all tests).
This means files in directories without a pom.xml (e.g. proposals/*.adoc, README.md)
cause findProjectRoot to return ".", and the script aborts all test execution — even
when the PR also contains real code changes.

For example, PR #23002 ran no tests because
it modified proposals/tracing.adoc.

Fix: Skip non-module files with continue instead of aborting. Root-level POM changes
are already handled separately by the grep and Scalpel dependency analysis in Step 2.

Test plan

  • PR that touches only proposals/*.adoc → no modules tested (correct, doc-only)
  • PR that touches proposals/*.adoc + component code → component tests run (was broken, now fixed)
  • PR that touches only component code → unchanged behavior

Files in directories without a pom.xml (e.g. proposals/*.adoc,
README.md) caused findProjectRoot to return "." which the script
treated as "root project changed", aborting all test execution.
This meant PRs touching any non-module file alongside real code
changes would run zero tests.

Skip these files and continue processing the remaining changes.
Root-level POM changes are already handled by the grep and Scalpel
dependency analysis.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@squakez
Copy link
Copy Markdown
Contributor

squakez commented May 11, 2026

Once merged, please let's close: CAMEL-23451

@gnodet gnodet changed the title ci: skip non-module files in incremental build instead of aborting CAMEL-23451: skip non-module files in incremental build instead of aborting May 11, 2026
@gnodet gnodet marked this pull request as ready for review May 11, 2026 09:24
@gnodet gnodet merged commit 05d593b into apache:main May 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants