[CAMEL-15196] adds support for opentracing tags#3919
Conversation
|
Copy that, thank you both. As a follow up question, at what point does it make sense to make this a fully fledged component? There are also methods for setting and retrieving "baggage" from Spans. I'm wondering if multiple processors or a component would be appropriate. |
|
This PR should be good to go :) though I wrote a little bit more about its approach and an alternative one over at https://issues.apache.org/jira/browse/CAMEL-15196 if you have a minute to read it over |
For my personal taste I'd prefer the second approach, but in terms of readability and correctness of implementation probably the processor approach seems better. |
|
Thanks @oscerd! If you have any directions about correctness of implementation I can definitely refactor it. Also, maybe we support both approaches? |
|
I think we need to go with just one approach to avoid confusion, I guess this one is ok :-) |
|
Fair enough :) |
|
I'll merge this today |
|
Merged on master |
|
Thanks |
Opentracing allows to set tags to a given Span, this exposes that functionality via a processor.
See: https://issues.apache.org/jira/browse/CAMEL-15196
https://opentracing.io/docs/overview/tags-logs-baggage/#tags
I'm still implementing some tests, but wanted to check with you guys first in case I'm headed down the wrong path.