Skip to content

ZooKeeperProducer does not stop ZooKeeper threads if Camel context ist stopped #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
klauss42 wants to merge 3 commits into from
Closed

ZooKeeperProducer does not stop ZooKeeper threads if Camel context ist stopped #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
491e07d
ZooKeeperProducer does not stop ZooKeeper threads if Camel context is…
Dec 19, 2013
65fde42
Avoid NPE
Dec 19, 2013
7f22df2
Allow comma-separated list of Zookeeper hosts in endpoint URI
Dec 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../camel-zookeeper/src/main/java/org/apache/camel/component/zookeeper/ConnectionHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ public void process(WatchedEvent event) {

public void closeConnection() {
try {
zookeeper.close();
if (zookeeper != null) {
zookeeper.close();
}
if (LOG.isDebugEnabled()) {
LOG.debug("Shutting down connection to Zookeeper cluster {}", configuration.getConnectString());
}
Expand Down
9 changes: 6 additions & 3 deletions ...amel-zookeeper/src/main/java/org/apache/camel/component/zookeeper/ZooKeeperComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,12 @@ protected Endpoint createEndpoint(String uri, String remaining, Map<String, Obje
}

private void extractConfigFromUri(String remaining, ZooKeeperConfiguration config) throws URISyntaxException {
URI u = new URI(remaining);
config.addZookeeperServer(u.getHost() + (u.getPort() != -1 ? ":" + u.getPort() : ""));
config.setPath(u.getPath());
URI fullUri = new URI(remaining);
String[] hosts = fullUri.getAuthority().split(",");
for (String host : hosts) {
config.addZookeeperServer(host.trim());
}
config.setPath(fullUri.getPath());
}

public ZooKeeperConfiguration getConfiguration() {
Expand Down
9 changes: 9 additions & 0 deletions ...camel-zookeeper/src/main/java/org/apache/camel/component/zookeeper/ZookeeperProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ public void process(Exchange exchange) throws Exception {
}
}

@Override
protected void doStop() throws Exception {
super.doStop();
if (log.isTraceEnabled()) {
log.trace(String.format("Shutting down zookeeper producer of '%s'", configuration.getPath()));
}
zkm.shutdown();
}

private void asynchronouslyDeleteNode(ZooKeeper connection, ProductionContext context) {
if (log.isDebugEnabled()) {
log.debug(format("Deleting node '%s', not waiting for confirmation", context.node));
Expand Down