VERACODE-659,660,663,664: Insufficient Entropy (CWE ID 331)

camel-core/src/main/java/org/apache/camel/processor/RedeliveryPolicy.java

@@ -17,7 +17,7 @@
 package org.apache.camel.processor;
 
 import java.io.Serializable;
-import java.util.Random;
+import java.security.SecureRandom;
 
 import org.apache.camel.Exchange;
 import org.apache.camel.LoggingLevel;
@@ -75,7 +75,7 @@
  * @version 
  */
 public class RedeliveryPolicy implements Cloneable, Serializable {
-    protected static Random randomNumberGenerator;
+    protected static SecureRandom randomNumberGenerator;
     private static final long serialVersionUID = -338222777701473252L;
     private static final Logger LOG = LoggerFactory.getLogger(RedeliveryPolicy.class);
 
@@ -217,7 +217,7 @@ public long calculateRedeliveryDelay(long previousDelay, int redeliveryCounter)
              * First random determines +/-, second random determines how far to
              * go in that direction. -cgs
              */
-            Random random = getRandomNumberGenerator();
+            SecureRandom random = getRandomNumberGenerator();
             double variance = (random.nextBoolean() ? collisionAvoidanceFactor : -collisionAvoidanceFactor)
                               * random.nextDouble();
             redeliveryDelayResult += redeliveryDelayResult * variance;
@@ -544,9 +544,9 @@ public void setUseExponentialBackOff(boolean useExponentialBackOff) {
         this.useExponentialBackOff = useExponentialBackOff;
     }
 
-    protected static synchronized Random getRandomNumberGenerator() {
+    protected static synchronized SecureRandom getRandomNumberGenerator() {
         if (randomNumberGenerator == null) {
-            randomNumberGenerator = new Random();
+            randomNumberGenerator = new SecureRandom();
         }
         return randomNumberGenerator;
     }

camel-core/src/main/java/org/apache/camel/processor/loadbalancer/RandomLoadBalancer.java

@@ -16,8 +16,8 @@
  */
 package org.apache.camel.processor.loadbalancer;
 
+import java.security.SecureRandom;
 import java.util.List;
-import java.util.Random;
 
 import org.apache.camel.Exchange;
 import org.apache.camel.Processor;
@@ -29,7 +29,7 @@
  */
 public class RandomLoadBalancer extends QueueLoadBalancer {
 
-    private static final Random RANDOM = new Random();
+    private static final SecureRandom RANDOM = new SecureRandom();
 
     protected synchronized Processor chooseProcessor(List<Processor> processors, Exchange exchange) {
         int size = processors.size();

camel-core/src/main/java/org/apache/camel/processor/loadbalancer/WeightedRandomLoadBalancer.java

@@ -16,14 +16,14 @@
  */
 package org.apache.camel.processor.loadbalancer;
 
+import java.security.SecureRandom;
 import java.util.List;
-import java.util.Random;
 
 import org.apache.camel.Exchange;
 import org.apache.camel.Processor;
 
 public class WeightedRandomLoadBalancer extends WeightedLoadBalancer {
-    private final Random rnd = new Random();
+    private final SecureRandom rnd = new SecureRandom();
     private final int distributionRatioSum;
     private int runtimeRatioSum;
 

camel-core/src/main/java/org/apache/camel/util/FileUtil.java

@@ -21,9 +21,9 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.nio.channels.FileChannel;
+import java.security.SecureRandom;
 import java.util.Iterator;
 import java.util.Locale;
-import java.util.Random;
 import java.util.Stack;
 
 import org.slf4j.Logger;
@@ -317,7 +317,7 @@ private static File createNewTempDir() {
         }
 
         // create a sub folder with a random number
-        Random ran = new Random();
+        SecureRandom ran = new SecureRandom();
         int x = ran.nextInt(1000000);
 
         File f = new File(s, "camel-tmp-" + x);