Skip to content

CAMEL-7102: Fix authentication tests of the camel-jcr component #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gzurowski wants to merge 2 commits into from
Closed

CAMEL-7102: Fix authentication tests of the camel-jcr component #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbc7e9
CAMEL-7102: Fix authentication tests of the camel-jcr component
gzurowski Jan 2, 2014
71ad304
CAMEL-7102: Rename authentication test classes of camel-jcr component.
gzurowski Jan 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions components/camel-jcr/src/test/java/org/apache/camel/component/jcr/JcrAuthTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,19 @@ protected Context createJndiContext() throws Exception {
user = userManager.createUser("test", "quatloos");
}
// set up permissions
String permissionsPath = session.getRootNode().getPath();
String path = session.getRootNode().getPath();
AccessControlManager accessControlManager = session
.getAccessControlManager();
AccessControlPolicyIterator acls = accessControlManager
.getApplicablePolicies(permissionsPath);
.getApplicablePolicies(path);
AccessControlList acl = null;
if (acls.hasNext()) {
AccessControlList acl = (AccessControlList) acls.nextAccessControlPolicy();
acl.addAccessControlEntry(user.getPrincipal(), accessControlManager
.getSupportedPrivileges(permissionsPath));
accessControlManager.setPolicy(permissionsPath, acl);
acl = (AccessControlList) acls.nextAccessControlPolicy();
} else {
throw new Exception("could not set access control for path "
+ permissionsPath);
acl = (AccessControlList) accessControlManager.getPolicies(path)[0];
}
acl.addAccessControlEntry(user.getPrincipal(), accessControlManager.getSupportedPrivileges(path));
accessControlManager.setPolicy(path, acl);

session.save();
session.logout();
Expand Down
7 changes: 4 additions & 3 deletions ...ponent/jcr/JcrAuthTokenWithLoginTest.java → ...ent/jcr/JcrAuthTokenLoginFailureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,22 @@
*/
package org.apache.camel.component.jcr;

import javax.jcr.LoginException;

import org.apache.camel.Exchange;
import org.apache.camel.builder.RouteBuilder;
import org.junit.Ignore;
import org.junit.Test;

public class JcrAuthTokenWithLoginTest extends JcrAuthTestBase {
public class JcrAuthTokenLoginFailureTest extends JcrAuthTestBase {

@Test
@Ignore("Fails with some error")
public void testCreateNodeWithAuthentication() throws Exception {
Exchange exchange = createExchangeWithBody("<message>hello!</message>");
Exchange out = template.send("direct:a", exchange);
assertNotNull(out);
String uuid = out.getOut().getBody(String.class);
assertNull("Expected body to be null, found JCR node UUID", uuid);
assertTrue("Wrong exception type", out.getException() instanceof LoginException);
}

@Override
Expand Down
4 changes: 1 addition & 3 deletions ...ponent/jcr/AuthTokenLoginFailureTest.java → .../component/jcr/JcrAuthTokenLoginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,11 @@

import org.apache.camel.Exchange;
import org.apache.camel.builder.RouteBuilder;
import org.junit.Ignore;
import org.junit.Test;

public class AuthTokenLoginFailureTest extends JcrAuthTestBase {
public class JcrAuthTokenLoginTest extends JcrAuthTestBase {

@Test
@Ignore("Fails with some error")
public void testCreateNodeWithAuthentication() throws Exception {
Exchange exchange = createExchangeWithBody("<message>hello!</message>");
Exchange out = template.send("direct:a", exchange);
Expand Down