Skip to content

Fixed columns to properly display csv#22

Closed
drgomesp wants to merge 1 commit intoapache:masterfrom
drgomesp:patch-1
Closed

Fixed columns to properly display csv#22
drgomesp wants to merge 1 commit intoapache:masterfrom
drgomesp:patch-1

Conversation

@drgomesp
Copy link

No description provided.

@drgomesp drgomesp closed this Jun 12, 2017
@drgomesp drgomesp deleted the patch-1 branch June 12, 2017 04:17
@hsluoyz
Copy link
Member

hsluoyz commented Jun 12, 2017

Hi @drgomesp ,

I know the CSV display provided by GitHub. But according to RFC 4180, a CSV should:

  1. is plain text using a character set such as ASCII, various Unicode character sets (e.g. UTF-8), EBCDIC, or Shift JIS,
  2. consists of records (typically one record per line),
  3. with the records divided into fields separated by delimiters (typically a single reserved character such as comma, semicolon, or tab; sometimes the delimiter may include optional spaces),
  4. where every record has the same sequence of fields.

So actually Casbin's CSV doesn't obey 4, which causes this issue.

But Casbin's policy doesn't need to be same number of columns, so I don't know if there's a better file format for Casbin policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants