Skip to content

CASSANALYTICS-140: Clean up non-ASCII characters in main source JavaDoc and comments#210

Open
tejaslodayadd wants to merge 1 commit into
apache:trunkfrom
tejaslodayadd:CASSANALYTICS-140-cleanup-non-ascii-javadoc
Open

CASSANALYTICS-140: Clean up non-ASCII characters in main source JavaDoc and comments#210
tejaslodayadd wants to merge 1 commit into
apache:trunkfrom
tejaslodayadd:CASSANALYTICS-140-cleanup-non-ascii-javadoc

Conversation

@tejaslodayadd
Copy link
Copy Markdown
Contributor

@tejaslodayadd tejaslodayadd requested a review from frankgh May 18, 2026 06:57
Copy link
Copy Markdown
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks for the fixes

…oc and comments

Several source files contain non-ASCII characters in JavaDoc and inline
comments (micro sign, rightwards arrow, em-dash). javac compiled with
the US-ASCII default encoding rejects these with "unmappable character"
errors, which the JIRA reproduces.

Replace the offenders in src/main/ across the affected modules with
ASCII-equivalent JavaDoc:

- micro sign 'mu' in time-unit lists in CreateSnapshotRequest,
  RequestContext, and SidecarClient becomes the HTML entity
  &apache#181;s. The 'mu-s' symbol still renders in generated Javadoc HTML
  but the source is ASCII.
- rightwards arrow in AbstractBulkWriterContext and RecordWriter
  becomes ->.
- em-dash in KafkaPublisher becomes --.

Test files are intentionally left untouched: their use of the two-dot
leader character matches the actual output of Guava's
com.google.common.collect.Range#toString and changing it would break
the assertions.

Patch by Tejas Lodaya for CASSANALYTICS-140
@tejaslodayadd tejaslodayadd force-pushed the CASSANALYTICS-140-cleanup-non-ascii-javadoc branch from 87207d4 to ba11e65 Compare May 18, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants