Skip to content

An experiment: simplifying the NativeImpl interface - #1425

Merged
absurdfarce merged 3 commits into
java2662from
java2662-simplification
Apr 13, 2020
Merged

An experiment: simplifying the NativeImpl interface#1425
absurdfarce merged 3 commits into
java2662from
java2662-simplification

Conversation

@absurdfarce

Copy link
Copy Markdown
Contributor

…ion throws to Native (where they belong)

@absurdfarce absurdfarce changed the title An experiment: simplifying the NativeImpl interface and moving except… An experiment: simplifying the NativeImpl interface Apr 8, 2020

@adutra adutra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Comment thread core/src/main/java/com/datastax/oss/driver/internal/core/os/JnrNativeImpl.java Outdated
@absurdfarce

Copy link
Copy Markdown
Contributor Author

@adutra Can you think of any reason this shouldn't be merged into the JAVA-2662 feature branch? I do think this is a stronger API and removing the abstract super-class makes me smile as well.

@adutra

adutra commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

@adutra Can you think of any reason this shouldn't be merged into the JAVA-2662 feature branch? I do think this is a stronger API and removing the abstract super-class makes me smile as well.

No, go ahead and merge it. And please feel empowered to just go ahead and do whatever you think is best, no need to wait for my input :-)

@absurdfarce
absurdfarce merged commit 3989135 into java2662 Apr 13, 2020
@absurdfarce
absurdfarce deleted the java2662-simplification branch April 13, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants