-
Notifications
You must be signed in to change notification settings - Fork 120
Trivial editing #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Trivial editing #305
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,10 +86,10 @@ CloudStack. We will go over the steps to prepare now. | |
| Operating System | ||
| ~~~~~~~~~~~~~~~~ | ||
|
|
||
| Using the CentOS 7.9.2009 minmal x86_64 install ISO, you'll need to install | ||
| Using the CentOS 7.9.2009 minimal x86_64 install ISO, you'll need to install | ||
| CentOS 7 on your hardware. The defaults will generally be acceptable for this | ||
| installation - but make sure to configure IP address/parameters so that you can later install needed | ||
| packages from internet. Later, we will change the network configuration as needed. | ||
| packages from the internet. Later, we will change the network configuration as needed. | ||
|
|
||
| Once this installation is complete, you'll want to gain access to your | ||
| server - through SSH. | ||
|
|
@@ -447,7 +447,7 @@ Install Python MySQL connector from the MySQL community repository (which we've | |
| # yum -y install mysql-connector-python | ||
|
|
||
| Please note that the previously required ``mysql-connector-java`` library is now bundled with CloudStack | ||
| Management server and is no more required to be installed separately. | ||
| Management server and is no longer required to be installed separately. | ||
|
|
||
| Installation | ||
| ~~~~~~~~~~~~ | ||
|
|
@@ -460,14 +460,14 @@ following command: | |
| # yum -y install cloudstack-management | ||
|
|
||
| CloudStack |version| requires Java 11 JRE. Installing the management server | ||
| will automatically install Java 11, but it's good to explicitly confirm that the Java 11 | ||
| will automatically install Java 11, but it's good to explicitly confirm that Java 11 | ||
| is the selected/active one (in case you had a previous Java version already installed): | ||
|
|
||
| .. parsed-literal:: | ||
|
|
||
| $ alternatives --config java | ||
|
|
||
| Make sure that Java 11 is the chosen one. | ||
| Make sure that Java 11 is selected. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I kind of like |
||
|
|
||
| With the application itself installed we can now setup the database, we'll do | ||
| that with the following command and options: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an English speaker but isn't it either
internetorthe Internet? (note the capitalisation)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm an English speaker, and it would be "the internet" or "the Internet". English isn't a single language though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradh, so capitalisation is optional if the article is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nouns (other than pronouns) are not usually capitalised.
Seriously though, its not a big deal. The only thing I was trying to do in this PR was fix the spelling mistake. I can back out the rest of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, don´t bother I'll merge