Skip to content

CLOUDSTACK-9211: Support passing vRAM size to support 3D GPU on Vmware #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 4 commits into from
Feb 23, 2016
Merged

CLOUDSTACK-9211: Support passing vRAM size to support 3D GPU on Vmware #1310

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
656ae10
CLOUDSTACK-9211: Support passing vRAM size to support 3D GPU on Vmware
nvazquez Jan 5, 2016
448b43f
CLOUDSTACK-9211: Add javadoc and refactor method
nvazquez Jan 14, 2016
4fcebfc
CLOUDSTACK-9211: Refactor vm vram size setter method
nvazquez Jan 18, 2016
b73c053
CLOUDSTACK-9211: Unit test for 3dgpu support
nvazquez Jan 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
CLOUDSTACK-9211: Support passing vRAM size to support 3D GPU on Vmware
  • Loading branch information
@nvazquez
nvazquez committed Jan 5, 2016
commit 656ae109377e7d4400d16f05cbb4096e20a8c05b
42 changes: 42 additions & 0 deletions plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
import com.vmware.vim25.VirtualMachineRelocateSpec;
import com.vmware.vim25.VirtualMachineRelocateSpecDiskLocator;
import com.vmware.vim25.VirtualMachineRuntimeInfo;
import com.vmware.vim25.VirtualMachineVideoCard;
import com.vmware.vim25.VmwareDistributedVirtualSwitchVlanIdSpec;

import org.apache.cloudstack.storage.command.StorageSubSystemCommand;
Expand Down Expand Up @@ -1895,6 +1896,9 @@ protected StartAnswer execute(StartCommand cmd) {

postDiskConfigBeforeStart(vmMo, vmSpec, sortedDisks, ideControllerKey, scsiControllerKey, iqnToPath, hyperHost, context);

//Sets video card memory to the one provided in detail svga.vramSize (if provided), 64MB was always set before
Copy link
Contributor

@cristofolini cristofolini Jan 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment like this would be better located in a Javadoc style comment above the postVideoCardMemoryConfigBeforeStart method itself, along with brief descriptions of the parameters involved. This could make it easier to read/understand going forward. :)

postVideoCardMemoryConfigBeforeStart(vmMo, vmSpec);

//
// Power-on VM
//
Expand Down Expand Up @@ -1943,6 +1947,44 @@ protected StartAnswer execute(StartCommand cmd) {
}
}

private void postVideoCardMemoryConfigBeforeStart(VirtualMachineMO vmMo, VirtualMachineTO vmSpec) {
String paramVRamSize = "svga.vramSize";
if (vmSpec.getDetails().containsKey(paramVRamSize)){
String value = vmSpec.getDetails().get(paramVRamSize);
try {
long svgaVmramSize = Long.parseLong(value);
for (VirtualDevice device : vmMo.getAllDeviceList()){
if (device instanceof VirtualMachineVideoCard){
VirtualMachineVideoCard videoCard = (VirtualMachineVideoCard) device;
if (videoCard.getVideoRamSizeInKB().longValue() != svgaVmramSize){
s_logger.info("Video card memory was set " + videoCard.getVideoRamSizeInKB().longValue() + "kb instead of " + svgaVmramSize + "kb");
videoCard.setVideoRamSizeInKB(svgaVmramSize);
videoCard.setUseAutoDetect(false);

VirtualDeviceConfigSpec arrayVideoCardConfigSpecs = new VirtualDeviceConfigSpec();
arrayVideoCardConfigSpecs.setDevice(videoCard);
arrayVideoCardConfigSpecs.setOperation(VirtualDeviceConfigSpecOperation.EDIT);

VirtualMachineConfigSpec changeVideoCardSpecs = new VirtualMachineConfigSpec();
changeVideoCardSpecs.getDeviceChange().add(arrayVideoCardConfigSpecs);

boolean res = vmMo.configureVm(changeVideoCardSpecs);
if (res) {
s_logger.info("Video card memory successfully updated to " + svgaVmramSize + "kb");
}
}
}
}
}
catch (NumberFormatException e){
s_logger.error("Unexpected value, cannot parse " + value + " to long due to: " + e.getMessage());
}
catch (Exception e){
s_logger.error("Error while reconfiguring vm due to: " + e.getMessage());
}
}
}

private void tearDownVm(VirtualMachineMO vmMo) throws Exception{

if(vmMo == null) return;
Expand Down