Skip to content

Deprecate AppCookie (App session) based stickiness type policy for Virtual Router#13315

Draft
sureshanaparti wants to merge 1 commit into
apache:4.20from
shapeblue:deprecate-appcookie-based-stickiness-type-for-vr
Draft

Deprecate AppCookie (App session) based stickiness type policy for Virtual Router#13315
sureshanaparti wants to merge 1 commit into
apache:4.20from
shapeblue:deprecate-appcookie-based-stickiness-type-for-vr

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Jun 1, 2026

Description

This PR deprecates AppCookie (App session) based stickiness type policy for Virtual Router, and some code improvements.

Fixes #3253

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Create VPC, network tier(s) and deploy instance on it.
  • Acquire public IP and configure load balancing rule.
  • On load balancing rule, configure sticky policy with 'AppCookie' method (this should fail with error).

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (357186d) to head (bfae704).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines Patch % Lines
...esource/virtualnetwork/VirtualRoutingResource.java 0.00% 13 Missing ⚠️
...ain/java/com/cloud/network/element/OvsElement.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13315      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
+ Complexity    13436    13433       -3     
============================================
  Files          5666     5666              
  Lines        500645   500640       -5     
  Branches      60801    60804       +3     
============================================
- Hits          81429    81412      -17     
- Misses       410106   410122      +16     
+ Partials       9110     9106       -4     
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.11% <17.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Copy Markdown
Member

I think, a simple solution might be

} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {

throwing an exception after this line

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load balancer appcookie configuration deprecated in HAproxy

3 participants