-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CLOUDSTACK-9726 Update state is not changed to UPDATE_FAILED in case … #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bvbharatk is there unit tests for this change? |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-533 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-891)
|
|
@borisstoyanov |
|
Thanks @bvbharatk, have you run any tests? If so, could you please share results? |
|
@borisstoyanov |
c3ee3d6 to
422787e
Compare
|
@borisstoyanov Test create network with non-default guest cidr with redundant routers ... === TestName: test_createRvRNetwork | Status : SUCCESS === |
…when Host is put in Maintenance Mode.
|
Did code review and based on the test result posted by @bvbharat , PR LGTM Test update network and check if VRs are updated in sequence ... === TestName: test_06_updateVRs_in_sequence | Status : SUCCESS === |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-690 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1049)
|
|
Ran marvin test /test/integration/component/maint/test_redundant_router.py. Test Results: Also manually tested the patch and failed the update network (by enabling maintenance on primary storage). Observed the update state of routers as "UPDATE_FAILED". Results are as expected. LGTM |

…when Host is put in Maintenance Mode.