CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[Slair1]

PR2094 made the log path a variable. The cloudstack-agent was modified to use the @agentlog@ variable entry, but the pom.xml file was not correct to do the replacement of the @agentlog@.

Line 62 of the pom.xml handles the replacement with the rename in place

[rafaelweingartner]

Thanks for the PR.
I restarted the Travis build to see if the errors were due to code or some other environment problem.

[yadvr]

Exactly like #2429

[borisstoyanov]

LGTM

[borisstoyanov]

@blueorangutan package

[blueorangutan]

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1757

[rafaelweingartner]

@Slair1 can you take a look into travis failures?

[Slair1]

Since this is the same as #2429, should we just back-merge that?

[yadvr]

Can you check the build failures @Slair1 ? (See travis for details, or confirm you're able to build without failures?).

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1779

[Slair1]

Travis errors look unrelated?

[rafaelweingartner]

Can you rebase? I have fixed a code that was causing travis errors.

[Slair1]

@rafaelweingartner sure, just did

[Slair1]

@rafaelweingartner still seeing some unrelated errors in the travis

[rafaelweingartner]

Hmmm, may I ask you why did you open the PR against 4.9?

[Slair1]

@rafaelweingartner as said in the other comments, there is already a PR that addresses this issue in future versions. We are running 4.9.3 right now in our environment.

[yadvr]

@Slair1 the changes are already in 4.11, master branches. By future version, do you expect the fix to be in a future 4.9.x version (likely 4.9.4.0)?

[rafaelweingartner]

Sorry for asking again, I forgot.
So, I was checking travis logs. It seems to be a timeout issue when downloading dependencies. Can you increase the travis timeouts and test it again?

[Slair1]

@rafaelweingartner yep, i was hoping it would be included in 4.9.4.0

[Slair1]

@rafaelweingartner how do i increase the travis timeouts?

[rafaelweingartner]

Timeouts can be changed in .travil.yml.
Are we going to have a 4.9.4.0? The version 4.9 is EOL.

[Slair1]

@rafaelweingartner thanks for info on increasing the travis timeout.

I guess i thought there would be a 4.9.4.0, there have been other PRs merged in 4.9 and the POMs for it have been updated to 4.9.4.0 it looks like at least.

[Slair1]

@rafaelweingartner sorry for the newbie question, but i updated the .travis.yml file and it now shows up in my commit, is that correct?

[yadvr]

Same as referenced PR in one of the comments, I'll merge this. However, on 4.9 and olders branches we no longer support Travis.