Skip to content

Fix Python code checkstyle execute by "systemvm\test\runtests.sh" #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelweingartner merged 4 commits into from
Apr 18, 2018
Merged

Fix Python code checkstyle execute by "systemvm\test\runtests.sh" #2576

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9dae29
dependencies update
rafaelweingartner Apr 17, 2018
a7641a8
Add extra blank line required by ...!?
rafaelweingartner Apr 17, 2018
17f44a2
fix W605 invalid escape sequence and more blank lines
rafaelweingartner Apr 17, 2018
c2d048e
print all installed python packages versions
rafaelweingartner Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
dependencies update
  • Loading branch information
@rafaelweingartner
rafaelweingartner committed Apr 17, 2018
commit b9dae2931a1e28b52be6526eb23c48a85642620c
6 changes: 3 additions & 3 deletions systemvm/test/runtests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
export PYTHONPATH="../debian/opt/cloud/bin/"
export PYTHONDONTWRITEBYTECODE=False

echo "Running pep8 to check systemvm/python code for errors"
pep8 --max-line-length=179 *py
pep8 --max-line-length=179 --exclude=monitorServices.py,baremetal-vr.py,passwd_server_ip.py `find ../debian -name \*.py`
echo "Running pycodestyle to check systemvm/python code for errors"
pycodestyle --max-line-length=179 *py
Copy link
Member

@yadvr yadvr Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelweingartner Why not retain using pep8?

Copy link
Member Author

@rafaelweingartner rafaelweingartner Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting a message that pep8 is deprecated and is being replaced by pycodestyle, that is why I replaced. It was one of my commits trying to solve the problem (or at least change some error message).

pycodestyle --max-line-length=179 --exclude=monitorServices.py,baremetal-vr.py,passwd_server_ip.py `find ../debian -name \*.py`
if [ $? -gt 0 ]
then
echo "Pylint failed, please check your code"
Expand Down
6 changes: 5 additions & 1 deletion tools/travis/before_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#

echo -e "#### System Information ####"
echo -e "\nO.S. information:"
echo $(uname -a)

echo -e "\nWho am I:"
whoami
Expand Down Expand Up @@ -100,7 +102,7 @@ pip install --user --upgrade pip

for ((i=0;i<$RETRY_COUNT;i++))
do
pip install --user --upgrade lxml paramiko nose texttable ipmisim pyopenssl mock flask netaddr pylint pep8 > /tmp/piplog
pip install --user --upgrade lxml paramiko nose texttable ipmisim pyopenssl mock flask netaddr pylint pycodestyle six astroid > /tmp/piplog
if [[ $? -eq 0 ]]; then
echo -e "\npython packages installed successfully"
break;
Expand All @@ -109,3 +111,5 @@ do
cat /tmp/piplog
done

echo -e "\nVersion of pip troublesome packages:\n"
echo $(pip freeze | grep -e six -e mock -e astroid -e enum34)