Updated vmware virtual hardware version in systemvmtemplate build script #3921
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadvr
requested changes
Feb 28, 2020
Member
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
Remove the shar archive script, lgtm
Member
|
ping @Spaceman1984 ^^ |
yadvr
approved these changes
Mar 3, 2020
Member
|
This needs to be manually tested by building a new systemvmtemplate and then run test matrix manually using backend jenkins. This can wait until 4.15. |
Member
|
@DaanHoogland @harikrishna-patnala how about we merge this on master and continue work in the other PR? The change LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull request updates the system VM template build script to use vmware hardware version 11 instead of 8.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
This was tested by running the build script before and after the change. No errors.