Fixes issue b/w Legacy and Primate UI wrt SessionID#4166
Fixes issue b/w Legacy and Primate UI wrt SessionID#4166Pearl1594 wants to merge 1 commit intoapache:4.13from
Conversation
|
@blueorangutan package |
|
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Add the fixes... Issue reference please |
|
Packaging result: ✔centos7 ✔debian. JID-1430 |
|
@blueorangutan test |
|
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
LGTM. Tested and able to login! |
|
Trillian test result (tid-1820)
|
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
| HttpSession finalSession = session; | ||
| List<Cookie> sessionKeys = Arrays.stream(cookies).filter(cookie -> cookie.getName().equals(ApiConstants.SESSIONKEY) | ||
| && cookie.getValue().equals(finalSession.getAttribute(ApiConstants.SESSIONKEY))).collect(Collectors.toList()); | ||
| Cookie validCookie = sessionKeys.get(0); |
There was a problem hiding this comment.
Why is the first cookie assumed the valid one? Is the core problem that more than one instance of sessionkey cookie exists?
There was a problem hiding this comment.
When there are 2 sessions opened (primate and legacy UI) to the same domain, there will be multiple sessionkey cookies
|
Trillian test result (tid-1824)
|
Description
When operating with both the legacy and Primate UI, due to clash in the sessionIDs generated during logins, one is unable to log in to Legacy UI once logged into Primate
Fix: If it is not a new session, then we use the latest session key (session ID in the cookies) for validation
Addresses issue: #4136
Types of changes