Skip to content

Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yadvr merged 1 commit into from
Oct 14, 2020
Merged

Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run #4373

yadvr merged 1 commit into from
Oct 14, 2020

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Oct 5, 2020

Description

modifyvxlan.sh script fails run as it isn't able to find the /var/run/cloud directory to create the lock file
Fixes: #4350

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

  • Deployed an Advanced zone with VXLAN as isolation method
  • deployed a VM in an isolated network

@Pearl1594 Pearl1594 changed the base branch from master to 4.14 October 5, 2020 13:51
@Pearl1594 Pearl1594 changed the base branch from 4.14 to master October 5, 2020 13:51
@Pearl1594 Pearl1594 changed the title creates /var/run/cloud folder for creation of lock file Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run Oct 5, 2020
@Pearl1594 Pearl1594 force-pushed the modify_vxlan_script_fix branch from 3dea86e to bc49564 Compare October 5, 2020 13:59
@Pearl1594 Pearl1594 changed the base branch from master to 4.14 October 5, 2020 13:59
@yadvr yadvr requested review from wido and yadvr October 6, 2020 05:27
DaanHoogland
DaanHoogland approved these changes Oct 6, 2020
View reviewed changes
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 6, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 6, 2020

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 6, 2020

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2123

@Pearl1594 Pearl1594 force-pushed the modify_vxlan_script_fix branch from bc49564 to 7c74142 Compare October 6, 2020 11:06
@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Oct 6, 2020

@blueorangutan package

@Pearl1594 Pearl1594 marked this pull request as ready for review October 6, 2020 11:07
@blueorangutan
Copy link

blueorangutan commented Oct 6, 2020

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.14.1.0 milestone Oct 6, 2020
@blueorangutan
Copy link

blueorangutan commented Oct 6, 2020

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2126

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Oct 6, 2020

@blueorangutan package

@wido
Copy link
Contributor

wido commented Oct 6, 2020

The big question: Why doesn't this exist?

I have never seen these issues with Ubuntu systems.

@yadvr
Copy link
Member

yadvr commented Oct 12, 2020

Ideally this must be created on pkg installation.
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 12, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 12, 2020

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2161

@wido
Copy link
Contributor

wido commented Oct 12, 2020

@rhtyd /var/run is a tmpfs on many systems nowadays, so the package can't fix this.

I just wonder why we (PCextreme) never run into this.

yadvr
yadvr approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will ensure the folder exists

@yadvr
Copy link
Member

yadvr commented Oct 14, 2020

Manually tested the logic on bash, LGTM. Merging based on travis tests and lgtms.

@yadvr yadvr merged commit cdcc914 into apache:4.14 Oct 14, 2020
@DaanHoogland DaanHoogland mentioned this pull request Nov 4, 2020
Closed
@levindecaro
Copy link
Contributor

levindecaro commented Nov 5, 2020

@DaanHoogland

I would like to report #4350 fixed create directory issue. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@wido wido Awaiting requested review from wido

Assignees

No one assigned

Labels

component:vxlan VXLAN Severity:Major type:bug

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

modifyvxlan.sh expect /var/run/cloud directory for LOCK, but directory require manual creation

6 participants

@Pearl1594 @DaanHoogland @blueorangutan @wido @yadvr @levindecaro