Skip to content

cks: use HttpsURLConnection for checking api server #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Mar 2, 2021
Merged

cks: use HttpsURLConnection for checking api server #4639

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d68a8
cks: use HttpsURLConnection for checking api server
shwstppr Feb 2, 2021
a31487c
ignore ssl certificate validation
shwstppr Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
cks: use HttpsURLConnection for checking api server 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
  • Loading branch information
@shwstppr
shwstppr committed Feb 2, 2021
commit 84d68a816a931b535d92d9214e660c82139fcdfd
12 changes: 9 additions & 3 deletions ...netes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,22 @@

package com.cloud.kubernetes.cluster.utils;

import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.InetSocketAddress;
import java.net.Socket;
import java.net.URL;
import java.util.stream.Collectors;

import javax.net.ssl.HttpsURLConnection;

import org.apache.commons.io.IOUtils;
import org.apache.log4j.Logger;

import com.cloud.kubernetes.cluster.KubernetesCluster;
import com.cloud.uservm.UserVm;
import com.cloud.utils.Pair;
import com.cloud.utils.StringUtils;
import com.cloud.utils.ssh.SshHelper;
import com.google.common.base.Strings;

Expand Down Expand Up @@ -218,7 +221,10 @@ public static boolean isKubernetesClusterServerRunning(final KubernetesCluster k
boolean k8sApiServerSetup = false;
while (System.currentTimeMillis() < timeoutTime) {
try {
String versionOutput = IOUtils.toString(new URL(String.format("https://%s:%d/version", ipAddress, port)), StringUtils.getPreferredCharset());
URL url = new URL(String.format("https://%s:%d/version", ipAddress, port));
HttpsURLConnection con = (HttpsURLConnection)url.openConnection();
Copy link
Member

@yadvr yadvr Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we configure it to ignore ssl cert validation?

Copy link
Contributor

@DaanHoogland DaanHoogland Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and get more static analysis reports as issues?

BufferedReader br = new BufferedReader(new InputStreamReader(con.getInputStream()));
String versionOutput = br.lines().collect(Collectors.joining());
if (!Strings.isNullOrEmpty(versionOutput)) {
if (LOGGER.isInfoEnabled()) {
LOGGER.info(String.format("Kubernetes cluster ID: %s API has been successfully provisioned, %s", kubernetesCluster.getUuid(), versionOutput));
Expand Down