conditional broadcastUri #5745
conditional broadcastUri #5745
Conversation
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
ui/src/config/section/network.js
Outdated
| details: ['name', 'id', 'description', 'type', 'traffictype', 'vpcid', 'vlan', 'broadcasturi', 'cidr', 'ip6cidr', 'netmask', 'gateway', 'aclname', 'ispersistent', 'restartrequired', 'reservediprange', 'redundantrouter', 'networkdomain', 'zonename', 'account', 'domain'], | ||
| columns: () => { | ||
| var fields = ['name', 'state', 'type', 'vpcname', 'cidr', 'ip6cidr', 'broadcasturi', 'domain', 'account', 'zonename'] | ||
| if (!['Admin'].includes(store.getters.userInfo.roletype)) { |
There was a problem hiding this comment.
may be, this can be moved to a util method isAdmin()
| if (!['Admin'].includes(store.getters.userInfo.roletype)) { | |
| if (!isAdmin()) { |
There was a problem hiding this comment.
makes sense but
$ grep -r isAdmin\ \(\)\ \{ ui/src/*
ui/src/views/compute/KubernetesServiceTab.vue: isAdmin () {
ui/src/views/network/CreateNetwork.vue: isAdmin () {
ui/src/views/network/UpdateNetwork.vue: isAdmin () {
ui/src/views/network/CreateIsolatedNetworkForm.vue: isAdmin () {
ui/src/views/network/CreateL2NetworkForm.vue: isAdmin () {
ui/src/views/network/CreateSharedNetworkForm.vue: isAdmin () {
ui/src/views/offering/AddComputeOffering.vue: isAdmin () {
ui/src/views/offering/AddDiskOffering.vue: isAdmin () {
ui/src/views/offering/AddNetworkOffering.vue: isAdmin () {
ui/src/views/offering/AddVpcOffering.vue: isAdmin () {
ui/src/views/offering/UpdateOfferingAccess.vue: isAdmin () {
I think it should also be unified and made available in a generic way, than.
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Verified UI, Broadcast URI column not displayed for user. |
|
Smoke tests not required for UI changes. Merging this based on the LGTMs, manual test and travis job. |
6 participants
Description
This PR...
Fixes: #5596
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?