ui: update vm haenable only for supported vms #5847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#5743 For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
sureshanaparti
requested review from
GabrielBrascher,
GutoVeronezi and
utchoang
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
|
Verified 'Edit instance' UI form with HA and non-HA compute offering for a stopped VM. LGTM. |
sureshanaparti
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5743
For VMs which have service offering that does not allow HA, haenable option will be not shown in the UpdateVM UI form.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
VM with offering that doesn't offer HA
VM with offering that offer HA
How Has This Been Tested?