[VMware][Deploy-as-is] OVF properties not importing when template is uploaded from local #5861

nvazquez · 2022-01-14T02:43:21Z

Description

This PR adds the missing template details when combining: OVA template upload from local + Read VM settings from OVA

Fixes: #5808

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Upload a OVA template from local
Verify the template_deploy_as_is_details table and the VM deployment wizard
Deploy VM and ensure properties/configurations/etc are set

nvazquez · 2022-01-14T02:43:34Z

@blueorangutan package

blueorangutan · 2022-01-14T02:44:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-14T04:34:32Z

Packaging result: ✔️ el7 ✖️ el8 ✔️ debian ✔️ suse15. SL-JID 2204

nvazquez · 2022-01-14T09:17:57Z

@blueorangutan package

blueorangutan · 2022-01-14T09:19:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-14T10:15:31Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2207

nvazquez · 2022-01-14T10:16:51Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-01-14T10:18:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

sureshanaparti

code LGTM

nvazquez · 2022-01-14T11:54:00Z

@blueorangutan package

blueorangutan · 2022-01-14T11:57:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-14T12:52:51Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2210

nvazquez · 2022-01-14T12:53:29Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-01-14T12:54:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-01-14T22:34:26Z

Trillian test result (tid-2878)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33626 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5861-t2878-vmware-67u3.zip
Smoke tests completed. 88 look OK, 4 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_change_service_offering_for_vm_with_snapshots	`Error`	5.57	test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	14.67	test_vm_snapshots.py
test_DeployVmAntiAffinityGroup	`Error`	42.67	test_affinity_groups.py
test_DeployVmAntiAffinityGroup_in_project	`Error`	206.14	test_affinity_groups_projects.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	32.85	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.03	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.03	test_kubernetes_clusters.py

sureshanaparti · 2022-01-17T05:05:17Z

@blueorangutan package

blueorangutan · 2022-01-17T05:06:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-17T06:20:55Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2222

DaanHoogland

clgtm

blueorangutan · 2022-01-17T10:17:03Z

@DaanHoogland unsupported parameters provided. Supported mgmt server os are: centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

DaanHoogland · 2022-01-17T10:30:01Z

@blueorangutan test centos7 vmware-67u3 keepEnv

blueorangutan · 2022-01-17T10:31:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

borisstoyanov

LGTM, manually uploaded a template and the properties were imported

nvazquez · 2022-01-24T11:05:38Z

@blueorangutan package

blueorangutan · 2022-01-24T11:06:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-01-24T11:55:45Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2285

sureshanaparti · 2022-01-24T12:19:38Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-01-24T12:20:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

sureshanaparti · 2022-01-25T05:30:45Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-01-25T05:31:03Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-01-25T16:52:35Z

Trillian test result (tid-2981)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39694 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5861-t2981-vmware-67u3.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_list_sec_storage_vm	`Failure`	0.03	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.03	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.03	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.03	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.03	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.03	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.03	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.03	test_ssvm.py
test_09_reboot_ssvm_forced	`Failure`	0.03	test_ssvm.py
test_10_reboot_cpvm_forced	`Failure`	0.03	test_ssvm.py
test_11_destroy_ssvm	`Failure`	0.03	test_ssvm.py
test_12_destroy_cpvm	`Failure`	908.84	test_ssvm.py

nvazquez · 2022-01-25T17:32:09Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-01-25T17:33:05Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-01-26T03:29:15Z

Trillian test result (tid-2992)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34515 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5861-t2992-vmware-67u3.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Fix ova upload missing details

cf56a6c

nvazquez added component:vmware component:templates labels Jan 14, 2022

nvazquez added this to the 4.16.1.0 milestone Jan 14, 2022

nvazquez self-assigned this Jan 14, 2022

nvazquez changed the base branch from main to 4.16 January 14, 2022 09:17

sureshanaparti approved these changes Jan 14, 2022

View reviewed changes

sureshanaparti requested review from DaanHoogland and harikrishna-patnala January 14, 2022 11:08

nvazquez added 2 commits January 14, 2022 08:37

Refactor and cleanup

1c1ec7d

Unused import

f8ac3a9

nvazquez marked this pull request as ready for review January 14, 2022 12:53

sureshanaparti added the status:needs-testing label Jan 14, 2022

nvazquez marked this pull request as draft January 14, 2022 13:29

apache deleted a comment from nvazquez Jan 17, 2022

apache deleted a comment from blueorangutan Jan 17, 2022

DaanHoogland approved these changes Jan 17, 2022

View reviewed changes

sureshanaparti assigned borisstoyanov Jan 18, 2022

borisstoyanov approved these changes Jan 24, 2022

View reviewed changes

nvazquez marked this pull request as ready for review January 24, 2022 11:05

DaanHoogland added status:ready-for-merge and removed status:needs-testing labels Jan 24, 2022

sureshanaparti merged commit 84f5768 into apache:4.16 Jan 26, 2022

sureshanaparti mentioned this pull request Jan 26, 2022

VMware: upload template from local is not importing OVF properties #5808

Closed

nvazquez deleted the fixovauploadasis branch February 12, 2022 02:36

DaanHoogland removed the status:ready-for-merge label Dec 4, 2024

[VMware][Deploy-as-is] OVF properties not importing when template is uploaded from local #5861

[VMware][Deploy-as-is] OVF properties not importing when template is uploaded from local #5861

Uh oh!

Conversation

nvazquez commented Jan 14, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

nvazquez commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

nvazquez commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

nvazquez commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

blueorangutan commented Jan 14, 2022

Uh oh!

sureshanaparti commented Jan 17, 2022

Uh oh!

blueorangutan commented Jan 17, 2022

Uh oh!

blueorangutan commented Jan 17, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 17, 2022

Uh oh!

DaanHoogland commented Jan 17, 2022

Uh oh!

blueorangutan commented Jan 17, 2022

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

sureshanaparti commented Jan 24, 2022

Uh oh!

blueorangutan commented Jan 24, 2022

Uh oh!

sureshanaparti commented Jan 25, 2022

Uh oh!

blueorangutan commented Jan 25, 2022

Uh oh!

blueorangutan commented Jan 25, 2022

Uh oh!

nvazquez commented Jan 25, 2022

Uh oh!