Respect VM UEFI details on first boot #5990

davidjumani · 2022-02-14T05:36:40Z

Description

Fixes #5913
Boots the VM based on the template UEFI setting

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

Check the smoke tests!

davidjumani · 2022-02-14T05:37:07Z

@blueorangutan package

blueorangutan · 2022-02-14T05:38:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-14T06:15:06Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2596

davidjumani · 2022-02-14T10:58:52Z

@blueorangutan package

blueorangutan · 2022-02-14T11:00:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

blueorangutan · 2022-02-14T11:37:22Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2599

davidjumani · 2022-02-14T11:38:29Z

@blueorangutan test

blueorangutan · 2022-02-14T11:39:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

GutoVeronezi · 2022-02-14T17:15:17Z

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

+        } catch (IllegalArgumentException e) {
+            String msg = String.format("Invalid %s: %s specified. Valid values are: %s",
+                    ApiConstants.BOOT_MODE, bootMode, Arrays.toString(ApiConstants.BootMode.values()));
+            s_logger.error(msg);


We could pass the exception as parameter of s_logger.error.

The exception is not thrown but logged instead. So explicitly throwing it in the following line

blueorangutan · 2022-02-14T20:57:49Z

Trillian test result (tid-3326)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32088 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5990-t3326-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

davidjumani · 2022-02-15T04:38:05Z

@blueorangutan package

blueorangutan · 2022-02-15T04:39:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T05:28:46Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2608

davidjumani · 2022-02-15T05:37:58Z

@blueorangutan package

blueorangutan · 2022-02-15T05:39:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T06:21:22Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2609

davidjumani · 2022-02-15T06:32:20Z

@blueorangutan test

blueorangutan · 2022-02-15T06:33:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-15T20:57:16Z

Trillian test result (tid-3333)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50416 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5990-t3333-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_07_deploy_kubernetes_ha_cluster	`Failure`	3607.93	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.06	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	81.03	test_kubernetes_clusters.py

nvazquez

LGTM - test failures are not related to this PR

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

davidjumani changed the title ~~Template boot type~~ Boot VM based on VM details Feb 14, 2022

davidjumani changed the title ~~Boot VM based on VM details~~ Respect VM UEFI details on first boot Feb 14, 2022

davidjumani added 3 commits February 14, 2022 12:30

Update settings only if API call is successful

ac37bf7

Validate template UEFI detail settings

ac86897

Read boot mode and type from vm details

cfbcfd4

davidjumani force-pushed the template-boot-type branch from fa6c75a to cfbcfd4 Compare February 14, 2022 07:00

davidjumani added 2 commits February 14, 2022 15:07

Cleanup

3ad086a

Honour boot type over templae settings

a1351ac

nvazquez reviewed Feb 14, 2022

View reviewed changes

server/src/main/java/com/cloud/template/TemplateManagerImpl.java Show resolved Hide resolved

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Show resolved Hide resolved

davidjumani added this to the 4.17.0.0 milestone Feb 14, 2022

davidjumani added the status:needs-review label Feb 14, 2022

davidjumani marked this pull request as ready for review February 14, 2022 11:31

GutoVeronezi reviewed Feb 14, 2022

View reviewed changes

Addressing comments

fea6a01

Explicitly thow exception

ec6ce48

davidjumani force-pushed the template-boot-type branch from f64d4af to ec6ce48 Compare February 15, 2022 05:05

nvazquez approved these changes Feb 16, 2022

View reviewed changes

davidjumani requested a review from GutoVeronezi February 16, 2022 04:28

harikrishna-patnala reviewed Feb 16, 2022

View reviewed changes

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Show resolved Hide resolved

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Show resolved Hide resolved

harikrishna-patnala approved these changes Feb 16, 2022

View reviewed changes

nvazquez merged commit d82cd55 into apache:main Feb 17, 2022

yadvr added the type:enhancement label Mar 24, 2022

Pearl1594 mentioned this pull request Jun 30, 2022

Launch template with UEFI boot type doesn't work at first time #6516

Closed

Respect VM UEFI details on first boot #5990

Respect VM UEFI details on first boot #5990

Uh oh!

Conversation

davidjumani commented Feb 14, 2022

Description

Types of changes

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

davidjumani commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

davidjumani commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

davidjumani commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

Uh oh!

Uh oh!

GutoVeronezi Feb 14, 2022

Choose a reason for hiding this comment

Uh oh!

davidjumani Feb 15, 2022

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

davidjumani commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

davidjumani commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

davidjumani commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants