Skip to content

travis: run nosetests-3.4 #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 1 commit into from
Mar 14, 2022
Merged

travis: run nosetests-3.4 #6113

nvazquez merged 1 commit into from
Mar 14, 2022

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 14, 2022

Description

This PR fixes #6097

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

yadvr
yadvr reviewed Mar 14, 2022
View reviewed changes
tools/travis/script.sh Outdated
for suite in "${TESTS[@]}" ; do
echo "Currently running test: $suite"
time nosetests --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator || true ;
time nosetests-2.7 --with-xunit --xunit-file=integration-test-results/$suite.xml --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/$suite.py -s -a tags=advanced,required_hardware=false --zone=Sandbox-simulator --hypervisor=simulator || true ;
Copy link
Member

@yadvr yadvr Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weizhouapache should this be nosetests-3.4? We moved to python3, so we should ensure to install dependencies via pip3 and run tests using nosetests-3.4?

Copy link
Member Author

@weizhouapache weizhouapache Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohityadavcloud
yes, the travis test still failed. it should be nosetest-3.4

@weizhouapache weizhouapache force-pushed the 4.16-fix-travis-nosetest2 branch from a58a636 to 83f0608 Compare March 14, 2022 09:41
@weizhouapache weizhouapache added this to the 4.17.0.0 milestone Mar 14, 2022
@weizhouapache weizhouapache changed the title travis: run nosetests-2.7 travis: run nosetests-3.4 Mar 14, 2022
@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 14, 2022

looks good now

$ travis_wait 40 ./tools/travis/script.sh ${TESTS}
Still running (1 of 40): ./tools/travis/script.sh smoke/test_certauthority_root
The command ./tools/travis/script.sh smoke/test_certauthority_root exited with 0.
Log:
Running tests:  smoke/test_certauthority_root
Currently running test: smoke/test_certauthority_root
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Mar_14_2022_10_19_30_A4ODM8 All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_issue_certificate_with_csr | Status : SUCCESS ===
=== TestName: test_issue_certificate_without_csr | Status : SUCCESS ===
=== TestName: test_list_ca_certificate | Status : SUCCESS ===
=== TestName: test_list_ca_providers | Status : SUCCESS ===
=== TestName: test_revoke_certificate | Status : SUCCESS ===
=== Final results are now copied to: /tmp/MarvinLogs/test_certauthority_root_XXWD3Y ===
real	0m4.441s
user	0m0.833s
sys	0m0.075s
+------+--------+------+-----------+
| Test | Result | Time | Test file |
+======+========+======+===========+
+------+--------+------+-----------+

@weizhouapache weizhouapache marked this pull request as ready for review March 14, 2022 11:41
@weizhouapache weizhouapache requested a review from nvazquez March 14, 2022 11:42
@nvazquez nvazquez closed this Mar 14, 2022
@nvazquez nvazquez reopened this Mar 14, 2022
@nvazquez
Copy link
Contributor

nvazquez commented Mar 14, 2022

Thanks @weizhouapache - had closed/opened to kick Travis again

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 14, 2022 •
edited
Loading

@nvazquez
travis test still failed - but it is NOT related to this PR

nvazquez
nvazquez approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - verified jobs are running again, thanks @weizhouapache

@weizhouapache weizhouapache mentioned this pull request Mar 14, 2022
Closed
@nvazquez nvazquez merged commit 6ff378f into apache:4.16 Mar 14, 2022
@nvazquez nvazquez mentioned this pull request Mar 14, 2022
Closed
@weizhouapache weizhouapache deleted the 4.16-fix-travis-nosetest2 branch December 9, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr left review comments

@nvazquez nvazquez nvazquez approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:travis Severity:BLOCKER

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @nvazquez @yadvr @sureshanaparti