Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Dec 27, 2022

Description

Fixes: #7025

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

see #7025

Fixes apache#7025

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 5096

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compilation errors

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from blueorangutan Dec 28, 2022
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 5105

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5112

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #7026 (1a9cdcb) into 4.17 (08881d6) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               4.17    #7026   +/-   ##
=========================================
  Coverage     10.36%   10.36%           
  Complexity     6628     6628           
=========================================
  Files          2453     2453           
  Lines        242386   242386           
  Branches      37928    37928           
=========================================
  Hits          25116    25116           
  Misses       214163   214163           
  Partials       3107     3107           
Impacted Files Coverage Δ
.../main/java/com/cloud/network/NetworkModelImpl.java 9.92% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr shwstppr marked this pull request as ready for review December 29, 2022 10:20
@yadvr
Copy link
Member

yadvr commented Dec 29, 2022

@blueorangutan test

@blueorangutan
Copy link

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-5694)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37121 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7026-t5694-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants