Allow volume migrations in ScaleIO within and across ScaleIO storage clusters #7408

harikrishna-patnala · 2023-04-06T08:36:57Z

Description

This feature allows the storage migration for ScaleIO volumes between the ScaleIO storage pools of the same and different ScaleIO storage clusters. Previously this operation was blocked and now we are allowing it from API/UI.

The volume migration within the same storage cluster is performed using ScaleIO’s native V-Tree migration operation where the volume will be live migrated to another storage pool. The volume migration across the different storage cluster is performed using libvirt’s live blockcopy operation which will first copy the volume to the destination storage pool and after a successful copy, the source volume will be deleted. Upon any failures during the block copy, source volume will remain to continue and other blockcopy operations will be reverted.

A document PR is added here apache/cloudstack-documentation#321

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

harikrishna-patnala · 2023-04-06T08:37:53Z

@blueorangutan package

blueorangutan · 2023-04-06T08:39:04Z

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-04-06T09:28:02Z

Packaging result: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 5869

codecov · 2023-04-06T09:34:45Z

Codecov Report

Merging #7408 (be81092) into 4.18 (1aa4f80) will increase coverage by 0.02%.
The diff coverage is 30.51%.

❗ Current head be81092 differs from pull request most recent head a4d04ab. Consider uploading reports for the commit a4d04ab to get more accurate results

@@             Coverage Diff              @@
##               4.18    #7408      +/-   ##
============================================
+ Coverage     12.98%   13.01%   +0.02%     
- Complexity     8989     9006      +17     
============================================
  Files          2716     2716              
  Lines        256343   256634     +291     
  Branches      39981    40017      +36     
============================================
+ Hits          33291    33403     +112     
- Misses       218886   219047     +161     
- Partials       4166     4184      +18

Impacted Files	Coverage Δ
...e/cloudstack/storage/volume/VolumeServiceImpl.java	`2.27% <0.00%> (-0.01%)`	⬇️
...oud/hypervisor/kvm/resource/LibvirtConnection.java	`0.00% <0.00%> (ø)`
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	`4.97% <0.00%> (-0.02%)`	⬇️
...age/datastore/client/ScaleIOGatewayClientImpl.java	`0.00% <0.00%> (ø)`
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	`0.00% <0.00%> (ø)`
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	`15.05% <0.00%> (+0.02%)`	⬆️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	`7.35% <ø> (+<0.01%)`	⬆️
...ce/wrapper/LibvirtMigrateVolumeCommandWrapper.java	`61.84% <74.40%> (+54.69%)`	⬆️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	`6.23% <100.00%> (ø)`

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

weizhouapache · 2023-04-06T09:36:15Z

@blueorangutan package

blueorangutan · 2023-04-06T09:37:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2023-04-06T09:47:26Z

SonarCloud Quality Gate failed.

2 Bugs
0 Vulnerabilities
0 Security Hotspots
15 Code Smells

8.7% Coverage
0.0% Duplication

blueorangutan · 2023-04-06T10:33:26Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5874

borisstoyanov · 2023-04-10T09:24:43Z

@blueorangutan test keepEnv

blueorangutan · 2023-04-10T09:25:03Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-04-10T22:48:44Z

Trillian test result (tid-6403)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46723 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6403-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

github-actions · 2023-05-25T21:11:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

harikrishna-patnala · 2023-05-31T11:59:20Z

@blueorangutan package

blueorangutan · 2023-05-31T12:00:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-05-31T12:35:49Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6183

harikrishna-patnala · 2023-06-01T03:40:11Z

@blueorangutan package

blueorangutan · 2023-06-01T03:42:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-06-01T04:21:58Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6190

harikrishna-patnala · 2023-06-15T07:23:58Z

@blueorangutan package

blueorangutan · 2023-06-15T07:26:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-06-15T08:05:44Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6236

harikrishna-patnala · 2023-06-16T08:22:07Z

@blueorangutan package

blueorangutan · 2023-06-16T08:24:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-06-16T09:03:46Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6248

borisstoyanov · 2023-06-19T08:02:44Z

@blueorangutan test matrix

blueorangutan · 2023-06-19T08:04:04Z

@borisstoyanov a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

harikrishna-patnala · 2023-06-19T11:46:34Z

@blueorangutan package

blueorangutan · 2023-06-19T11:48:03Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-06-19T12:26:47Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6266

borisstoyanov · 2023-06-19T14:12:51Z

@blueorangutan test

blueorangutan · 2023-06-19T14:14:03Z

@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-06-19T19:42:20Z

[SF] Trillian test result (tid-6760)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40579 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6760-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-06-19T21:14:16Z

[SF] Trillian test result (tid-6762)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45976 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6762-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	78.68	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	57.52	test_vm_life_cycle.py

blueorangutan · 2023-06-20T00:10:09Z

[SF] Trillian test result (tid-6761)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 56589 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6761-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	`Error`	18.73	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3605.89	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	40.36	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	3604.32	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	11.55	test_vm_deployment_planner.py

blueorangutan · 2023-06-20T03:27:23Z

[SF] Trillian test result (tid-6765)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46162 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6765-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	83.95	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	52.30	test_vm_life_cycle.py

borisstoyanov · 2023-06-20T08:14:03Z

[SF] Trillian test result (tid-6761) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 56589 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6761-vmware-67u3.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_deploy_vm_on_specific_host Error 18.73 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 3605.89 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 40.36 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 3604.32 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 11.55 test_vm_deployment_planner.py

Manually passed

=== TestName: test_01_deploy_vm_on_specific_host | Status : SUCCESS ===

=== TestName: test_02_deploy_vm_on_specific_cluster | Status : SUCCESS ===

=== TestName: test_03_deploy_vm_on_specific_pod | Status : SUCCESS ===

=== TestName: test_04_deploy_vm_on_host_override_pod_and_cluster | Status : SUCCESS ===

=== TestName: test_05_deploy_vm_on_cluster_override_pod | Status : SUCCESS ===

borisstoyanov · 2023-06-20T08:20:08Z

[SF] Trillian test result (tid-6765) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46162 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6765-kvm-centos7.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 83.95 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 52.30 test_vm_life_cycle.py

This has been seen in other 4.18 PRs as well, it's not related to the changes of this PR

borisstoyanov

LGTM, manually tested.

borisstoyanov · 2023-07-17T08:28:04Z

@blueorangutan package

blueorangutan · 2023-07-17T08:30:04Z

@borisstoyanov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-07-17T08:31:32Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6493

boring-cyborg bot added component:compute component:kvm component:orchestration component:primary-storage component:storage labels Apr 6, 2023

harikrishna-patnala marked this pull request as draft April 6, 2023 08:47

github-actions bot added the status:has-conflicts label May 25, 2023

harikrishna-patnala force-pushed the LiveStoragMigrationScaleIOMain branch from 0827495 to 619e753 Compare May 31, 2023 11:59

boring-cyborg bot added component:integration-test component:UI Python Warning... Python code Ahead! labels May 31, 2023

github-actions bot removed the status:has-conflicts label May 31, 2023

harikrishna-patnala force-pushed the LiveStoragMigrationScaleIOMain branch from 659d062 to c3ff286 Compare June 15, 2023 07:23

Fixed passphrase check

be81092

Add image options to the encypted volume conversion

a4d04ab

borisstoyanov approved these changes Jun 20, 2023

View reviewed changes

harikrishna-patnala marked this pull request as ready for review June 21, 2023 06:26

harikrishna-patnala merged commit 40cc10a into apache:4.18 Jun 21, 2023

weizhouapache mentioned this pull request Sep 5, 2023

Local Storage migration fails due to storage pool not found on destination KVM host #7942

Closed

mlsorensen mentioned this pull request Jan 3, 2024

Fix libvirt domain event listener by properly processing events #8437

Merged

13 tasks

Allow volume migrations in ScaleIO within and across ScaleIO storage clusters #7408

Allow volume migrations in ScaleIO within and across ScaleIO storage clusters #7408

Uh oh!

Conversation

harikrishna-patnala commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

harikrishna-patnala commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

codecov bot commented Apr 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

sonarqubecloud bot commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

borisstoyanov commented Apr 10, 2023

Uh oh!

blueorangutan commented Apr 10, 2023

Uh oh!

blueorangutan commented Apr 10, 2023

Uh oh!

github-actions bot commented May 25, 2023

Uh oh!

harikrishna-patnala commented May 31, 2023

Uh oh!

blueorangutan commented May 31, 2023

Uh oh!

blueorangutan commented May 31, 2023

Uh oh!

harikrishna-patnala commented Jun 1, 2023

Uh oh!

blueorangutan commented Jun 1, 2023

Uh oh!

blueorangutan commented Jun 1, 2023

Uh oh!

harikrishna-patnala commented Jun 15, 2023

Uh oh!

blueorangutan commented Jun 15, 2023

Uh oh!

blueorangutan commented Jun 15, 2023

Uh oh!

harikrishna-patnala commented Jun 16, 2023

Uh oh!

blueorangutan commented Jun 16, 2023

Uh oh!

blueorangutan commented Jun 16, 2023

Uh oh!

borisstoyanov commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

harikrishna-patnala commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

borisstoyanov commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

harikrishna-patnala commented Apr 6, 2023 •

edited

Loading

codecov bot commented Apr 6, 2023 •

edited

Loading

borisstoyanov commented Jun 20, 2023 •

edited

Loading