Skip to content

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Aug 23, 2023

The .python-version file is using Python 3.6 which is really 3.6.15.

When installing pre-commit with pip under 3.6 it installs pre-commit version 2.17.0.

So I have downgraded the min pre-commit version.

Also I have removed the cloudmonkey package from the requirements file as we now use the Go CLI

When using Python 3 you cannot even install the original requirments.txt file.

The pre-commit package has also been added to the requirements file

Description

This PR fixes the requirements file and it will now install the Python packages

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2023-08-24 01-22-02

Screenshot from 2023-08-24 01-22-26

How Has This Been Tested?

Main steps were:

Installed python 3.6 with pyenv

I created a "cloudstack" virtualenv with pyenv and then installed the requirements file.

Then tested running pre-commit.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6872

The `.python-version` file is using Python 3.6 which is really `3.6.15`.

When installing pre-commit with pip under 3.6 it installs pre-commit version `2.17.0`.

So I have downgraded the min pre-commit version.

Also I have removed the cloudmonkey package from the requirements file as we now use the Go CLI

When using Python 3 you cannot even install the original requirments.txt file.

The pre-commit package has also been added to the requirements file
@DaanHoogland DaanHoogland force-pushed the update-requirements-file branch from 03c4fc1 to 9e3f5f1 Compare September 29, 2023 12:57
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #7901 (9e3f5f1) into main (a256604) will increase coverage by 0.94%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7901      +/-   ##
============================================
+ Coverage     28.30%   29.24%   +0.94%     
- Complexity    29161    30501    +1340     
============================================
  Files          5100     5100              
  Lines        358547   358547              
  Branches      52322    52322              
============================================
+ Hits         101490   104873    +3383     
+ Misses       243113   239285    -3828     
- Partials      13944    14389     +445     
Flag Coverage Δ
simulator-marvin-tests 25.22% <ø> (+1.18%) ⬆️
uitests 4.86% <ø> (ø)
unit-tests 14.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 242 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# under the License.

# Install the latest version of cloudmonkey
cloudmonkey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this put here (old python version of cloudmonkey maybe)?

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 10, 2023

for the sake of the change in requirements.txt I am going to run regression

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@apache apache deleted a comment from blueorangutan Oct 31, 2023
@apache apache deleted a comment from blueorangutan Oct 31, 2023
@apache apache deleted a comment from blueorangutan Oct 31, 2023
@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7588

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-8195)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44873 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7901-t8195-kvm-centos7.zip
Smoke tests completed. 113 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 336.99 test_safe_shutdown.py
test_02_upgrade_kubernetes_cluster Failure 553.71 test_kubernetes_clusters.py

@DaanHoogland
Copy link
Contributor

failing tests are not due to this change or all would fail. agree @shwstppr ?

@DaanHoogland DaanHoogland merged commit 7b31a51 into apache:main Nov 10, 2023
@jbampton jbampton deleted the update-requirements-file branch November 10, 2023 11:38
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants