-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update requirements file and fix minimum pre-commit version #7901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@blueorangutan package |
|
@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6872 |
The `.python-version` file is using Python 3.6 which is really `3.6.15`. When installing pre-commit with pip under 3.6 it installs pre-commit version `2.17.0`. So I have downgraded the min pre-commit version. Also I have removed the cloudmonkey package from the requirements file as we now use the Go CLI When using Python 3 you cannot even install the original requirments.txt file. The pre-commit package has also been added to the requirements file
03c4fc1 to
9e3f5f1
Compare
Codecov Report
@@ Coverage Diff @@
## main #7901 +/- ##
============================================
+ Coverage 28.30% 29.24% +0.94%
- Complexity 29161 30501 +1340
============================================
Files 5100 5100
Lines 358547 358547
Branches 52322 52322
============================================
+ Hits 101490 104873 +3383
+ Misses 243113 239285 -3828
- Partials 13944 14389 +445
Flags with carried forward coverage won't be shown. Click here to find out more. see 242 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| # under the License. | ||
|
|
||
| # Install the latest version of cloudmonkey | ||
| cloudmonkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this put here (old python version of cloudmonkey maybe)?
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
for the sake of the change in requirements.txt I am going to run regression |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7588 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-8195)
|
|
failing tests are not due to this change or all would fail. agree @shwstppr ? |
The
.python-versionfile is using Python 3.6 which is really3.6.15.When installing pre-commit with pip under 3.6 it installs pre-commit version
2.17.0.So I have downgraded the min pre-commit version.
Also I have removed the cloudmonkey package from the requirements file as we now use the Go CLI
When using Python 3 you cannot even install the original requirments.txt file.
The pre-commit package has also been added to the requirements file
Description
This PR fixes the requirements file and it will now install the Python packages
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Main steps were:
Installed python 3.6 with pyenv
I created a "cloudstack" virtualenv with pyenv and then installed the requirements file.
Then tested running pre-commit.