Skip to content

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Aug 29, 2023

Description

This PR fixes the smoke test test_vm_autoscaling.py which failed at the setup stage , because the autoscale vm profile uses a userdata which does not have a header.

it worked with 4.18, but not with main due to #7918

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Aug 29, 2023
@weizhouapache
Copy link
Member Author

@blueorangutan LLpackage

@blueorangutan
Copy link

@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6171

@weizhouapache
Copy link
Member Author

@blueorangutan LLtest

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #7921 (9cf9642) into main (40d7da6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7921      +/-   ##
============================================
- Coverage     14.40%   14.39%   -0.01%     
  Complexity    10108    10108              
============================================
  Files          2748     2748              
  Lines        259404   259404              
  Branches      40391    40391              
============================================
- Hits          37358    37354       -4     
- Misses       217210   217218       +8     
+ Partials       4836     4832       -4     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weizhouapache
Copy link
Member Author

@blueorangutan LLtest

@blueorangutan
Copy link

@weizhouapache a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[LL]Trillian test result (tid-6730)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43914 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7921-t6730-kvm-centos7.zip

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.19.0.0 milestone Aug 30, 2023
@blueorangutan
Copy link

[SF] Trillian test result (tid-7604)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44795 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7921-t7604-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 331.85 test_safe_shutdown.py
test_08_upgrade_kubernetes_ha_cluster Failure 702.53 test_kubernetes_clusters.py

@weizhouapache weizhouapache merged commit 78411fd into apache:main Aug 30, 2023
@DaanHoogland DaanHoogland deleted the 4.19-fix-test_vm_autoscaling branch August 31, 2023 06:57
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Oct 12, 2023
…improvement (apache#7921)

(cherry picked from commit 78411fd)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants