kvm: fix live vm migration between local storage pools

[weizhouapache]

Description

This PR fixes #7942

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[yadvr]

LGTM tested this on a 3-host Ubuntu 22.04 kvm cluster and with this patch I'm no longer facing errors when live migrating VMs with local storage. Surpringly, this happens in my env when disk sizes are large (>20GB).

[harikrishna-patnala]

LGTM

I've tested the fix with PowerFlex storage migrations to see if it has any effects but all are working fine. This was initially added during development of powerflex volume migrations.

[weizhouapache]

thanks a lot @rohityadavcloud @harikrishna-patnala for your discussion and verification !

[codecov]

Codecov Report

Merging #7945 (b033e19) into 4.18 (57c61fb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7945      +/-   ##
============================================
- Coverage     13.06%   13.06%   -0.01%     
+ Complexity     9097     9096       -1     
============================================
  Files          2720     2720              
  Lines        257465   257464       -1     
  Branches      40146    40146              
============================================
- Hits          33643    33634       -9     
- Misses       219594   219603       +9     
+ Partials       4228     4227       -1     

Files Changed	Coverage Δ
...oud/hypervisor/kvm/resource/LibvirtConnection.java	0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6986

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[weizhouapache]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[weizhouapache]

@blueorangutan test alma8 kvm-alma8

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests

[weizhouapache]

@blueorangutan test ubuntu22 kvm-ubuntu22

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[blueorangutan]

[SF] Trillian test result (tid-7633)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43235 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7945-t7633-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-7638)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 45912 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7945-t7638-kvm-ubuntu22.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn_multiple_options	Failure	758.38	test_vpc_vpn.py

[blueorangutan]

[SF] Trillian test result (tid-7634)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 55646 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7945-t7634-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-7635)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 67636 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7945-t7635-kvm-alma8.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	1197.34	test_kubernetes_clusters.py