Skip to content

New API "checkVolume" to check and repair any leaks or issues reported by qemu-img check #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 23 commits into from
Feb 29, 2024
Merged

New API "checkVolume" to check and repair any leaks or issues reported by qemu-img check #8577

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2a5ca85
Introduced a new API checkVolumeAndRepair that allows users or admins…
harikrishna-patnala Feb 20, 2024
af4c422
some fixes
harikrishna-patnala Feb 20, 2024
a365b45
Added unit tests
harikrishna-patnala Feb 20, 2024
f52c819
addressed review comments
harikrishna-patnala Feb 20, 2024
08d3c06
add repair volume while granting access
harikrishna-patnala Jan 10, 2024
3b5514d
Changed repair parameter to accept both leaks/all
harikrishna-patnala Jan 30, 2024
ef1bbdd
Introduced new global setting volume.check.and.repair.before.use to d…
harikrishna-patnala Jan 30, 2024
369e567
Added volume check and repair changes only during VM start and volume…
harikrishna-patnala Jan 12, 2024
6402882
Refactored the names to look similar across the code
harikrishna-patnala Jan 30, 2024
8e4017d
Some code fixes
harikrishna-patnala Jan 29, 2024
a5d3999
remove unused code
harikrishna-patnala Jan 30, 2024
a109da1
Renamed repair values
harikrishna-patnala Jan 30, 2024
d6495c4
Fixed unit tests
harikrishna-patnala Jan 30, 2024
6ff875f
changed version
harikrishna-patnala Jan 30, 2024
a143e82
Address review comments
harikrishna-patnala Feb 20, 2024
3dc2dd9
Code refactored
harikrishna-patnala Feb 1, 2024
c805940
used volume name in logs
harikrishna-patnala Feb 1, 2024
cac4418
Changed the API to Async and the setting scope to storage pool
harikrishna-patnala Feb 5, 2024
0b88d52
Fixed exit value handling with check volume command
harikrishna-patnala Feb 7, 2024
1596d14
Fixed storage scope to the setting
harikrishna-patnala Feb 8, 2024
fb1026b
Fix volume format issues
harikrishna-patnala Feb 20, 2024
2dfeece
Refactored the log messages
harikrishna-patnala Feb 20, 2024
30fa612
Fix formatting
harikrishna-patnala Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix formatting
  • Loading branch information
@harikrishna-patnala
harikrishna-patnala committed Feb 22, 2024
commit 30fa6128b3230ac7518fdfbbe30c51c95aac83d0
2 changes: 1 addition & 1 deletion utils/src/main/java/com/cloud/utils/script/Script.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ public String executeIgnoreExitValue(OutputInterpreter interpreter, int exitValu
}

while (true) {
_logger.debug(String.format("Executing while with timeout : %d" + _timeout));
_logger.debug(String.format("Executing while with timeout : %d", _timeout));
try {
//process execution completed within timeout period
if (_process.waitFor(_timeout, TimeUnit.MILLISECONDS)) {
Expand Down