engine-schema,test: fix domain reservation searchbuilder, test fixes

[shwstppr]

Description

The SearchBuilder listDomainAndTypeAndNoTagSearch in ReservationDaoImpl.java is wrongly created by adding ACCOUNT_ID as part of the search param. Instead it should be DOMAIN_ID.
Additional fixes in test cases to:

• add assert
• add spacing

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[vishesh92]

clgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.98%. Comparing base (6f27b1f) to head (e8114e5).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8725      +/-   ##
============================================
+ Coverage     30.97%   30.98%   +0.01%     
- Complexity    33481    33505      +24     
============================================
  Files          5355     5355              
  Lines        375830   375830              
  Branches      54895    54895              
============================================
+ Hits         116414   116467      +53     
+ Misses       243974   243936      -38     
+ Partials      15442    15427      -15     

Flag	Coverage Δ
simulator-marvin-tests	24.86% <100.00%> (+0.02%)	⬆️
uitests	4.36% <ø> (ø)
unit-tests	16.57% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8815

[sureshanaparti]

code lgtm

[sureshanaparti]

@shwstppr can this be targeted for 4.19.1?

[shwstppr]

@sureshanaparti I guess the change was introduced in #8362 therefore it needs to be in main only

[sureshanaparti]

@sureshanaparti I guess the change was introduced in #8362 therefore it needs to be in main only

ok, thanks @shwstppr

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[borisstoyanov]

LGTM

[blueorangutan]

[SF] Trillian test result (tid-9348)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46908 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8725-t9348-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[shwstppr]

Merging based on approvals and test results