CLOUDSTACK-8897: baremetal:addHost:make host tag info mandtory in bar…

[harikrishna-patnala]

CLOUDSTACK-8897: baremetal:addHost:make host tag info mandtory in baremetal addhost Api call

addhost api is successful with out providing the host tag info and we recommend host tag is mandatory for bare-metal.
In the current implementation host tag check is happening at vm deployment stage but it will be good to have host tag field as mandatory field during adding of the host

[asfbot]

cloudstack-pull-rats #700 SUCCESS
This pull request looks good

[asfbot]

cloudstack-pull-analysis #650 SUCCESS
This pull request looks good

[sebgoa]

We won't be able to test this on simulator.
@harikrishna-patnala can you answer @borisroman and then we can merge.
LGTM +1 on code review alone

[alexandrelimassantana]

Hey @harikrishna-patnala just a little tip on line 684. You could use Apache Commons' CollectionUtils to make such checks, it does exactly the same thing but is a little more clean. But that's just a little adjustment. http://commons.apache.org/proper/commons-collections/javadocs/api-release/org/apache/commons/collections4/CollectionUtils.html#isEmpty(java.util.Collection)

[yadvr]

@harikrishna-patnala please rebase against latest master and push -f, update on status of your PR

LGTM
tag:easypr

[bvbharatk]

ACS CI BVT Run

Sumarry:
Build Number 105
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=1
Skipped=3

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

• test_vm_life_cycle.py
  • test_10_attachAndDetach_iso Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

[harikrishna-patnala]

I have updated the PR based on the comments. Please review.

[cloudmonger]

ACS CI BVT Run

Sumarry:
Build Number 411
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=2
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

• test_routers_network_ops.py

• test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed

• test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

[harikrishna-patnala]

There are 2 failed test cases which are failing on all other PRs

[kishankavala]

LGTM

[harikrishna-patnala]

tag:mergeready