Fix WordUtils.wrap for wrapOn matches different from one character#1655
Merged
Conversation
`WordUtils.wrap` advanced the offset by a single character past each `wrapOn` match, assuming the separator is always exactly one character long: - When the `wrapOn` regex matched several characters, the surplus separator characters were left in the wrapped output instead of being consumed, - When the `wrapOn` regex matched zero characters, one additional character was consumed. Now it tracks the end offset of each match and resume from there, so that separators of any length, including zero-width matches, are skipped correctly.
7 tasks
Member
|
@ppkarwasz |
Member
Author
|
@garydgregory, no problem. I saw your message on the mailing list (thread) and will submit PRs from my fork going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordUtils.wrapadvanced the offset by a single character past eachwrapOnmatch, assuming the separator is always exactly one character long:wrapOnregex matched several characters, the surplus separator characters were left in the wrapped output instead of being consumed,wrapOnregex matched zero characters, one additional character was consumed.Now it tracks the end offset of each match and resume from there, so that separators of any length, including zero-width matches, are skipped correctly.