Skip to content

DateUtils.parseDateWithLeniency() doesn't reset its time zone#1660

Merged
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/DateUtils_parseDateWithLeniency_time_zone
May 18, 2026
Merged

DateUtils.parseDateWithLeniency() doesn't reset its time zone#1660
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/DateUtils_parseDateWithLeniency_time_zone

Conversation

@garydgregory
Copy link
Copy Markdown
Member

DateUtils.parseDateWithLeniency() doesn't reset its time zone

Calendar.clear() does not reset the time zone. A previous TZ-aware pattern (for example, "z", "zz", "Z", "X..") that partially parsed could have mutated the calendar's time zone via Calendar.setTimeZone(...) before failing on the remaining tokens. Restore the caller-supplied zone for each attempt so the outcome of pattern N+1 does not depend on the partial state left by pattern N.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

doesn't reset its time zone

Calendar.clear() does not reset the time zone. A previous TZ-aware
pattern (for example, "z", "zz", "Z", "X..") that partially parsed could
have
mutated the calendar's time zone via Calendar.setTimeZone(...) before
failing on the remaining tokens. Restore the caller-supplied zone for
each
attempt so the outcome of pattern N+1 does not depend on the partial
state left by pattern N.
@garydgregory garydgregory merged commit 526a03a into apache:master May 18, 2026
37 of 52 checks passed
@garydgregory garydgregory deleted the fix/DateUtils_parseDateWithLeniency_time_zone branch May 18, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant