Open
Conversation
raphinesse
reviewed
Jul 24, 2018
raphinesse
left a comment
raphinesse
left a comment
There was a problem hiding this comment.
At first glance, this seems like a good plan to me. 👍
| let pkgJson = new PackageHelper('package.json') | ||
|
|
||
| // TODO: See if there's an easy way to determine if the platform is already | ||
| // installed with a matching version and avoid the npm invocation |
There was a problem hiding this comment.
cordova-fetch already does this, so you can just call it and use the path to the installed package it returns to determine the package name too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for splitting the behaviour of
cordova platform addinto several smaller steps that could be reused by other parts of the tooling and more easily tested.See also: apache/cordova-common#34 for a first pass at some of the lower-level package.json support needed for this.
/fyi @raphinesse @erisu @brodybits