This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Merged
Conversation
timbru31
approved these changes
Dec 7, 2020
Member
timbru31
left a comment
There was a problem hiding this comment.
LGTM, IMO we should not merge this yet and coordinate it together with the cordova-android change.
NiklasMerz
approved these changes
Apr 13, 2021
breautek
approved these changes
Apr 14, 2021
jcesarmobile
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation, Context & Description
This plugin, which only supports Android, is being integrated into the core of the Cordova Android platform.
apache/cordova-android#1138
This plugin will no longer be required in the next major release of Cordova Android, if the PR is merged in before release.
Checklist