Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

breaking: deprecate plugin#59

Merged
erisu merged 2 commits intoapache:masterfrom
erisu:chore/deprecate
Apr 27, 2021
Merged

breaking: deprecate plugin#59
erisu merged 2 commits intoapache:masterfrom
erisu:chore/deprecate

Conversation

@erisu
Copy link
Member

@erisu erisu commented Dec 3, 2020

Platforms affected

Android

Motivation, Context & Description

This plugin, which only supports Android, is being integrated into the core of the Cordova Android platform.

apache/cordova-android#1138

This plugin will no longer be required in the next major release of Cordova Android, if the PR is merged in before release.

Checklist

  • I've updated the documentation if necessary

@erisu erisu requested review from dpogue and purplecabbage December 3, 2020 10:30
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, IMO we should not merge this yet and coordinate it together with the cordova-android change.

@erisu erisu requested a review from jcesarmobile April 27, 2021 14:21
@erisu erisu marked this pull request as ready for review April 27, 2021 14:31
@erisu erisu merged commit 83b77a5 into apache:master Apr 27, 2021
@erisu erisu deleted the chore/deprecate branch April 27, 2021 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants