This repository was archived by the owner on May 25, 2021. It is now read-only.
add_node: Don't fail if node name != "couchdb" or "node1" - #11
Merged
Conversation
Adding nodes to a cluster fails if the node names (the `name` of
`name@hostname` in vm.args) is different from "couchdb".
The code currently infers this name from the port: "node1" if 15984,
"node2" if 25984, "node3" if 35984, "couchdb" otherwise. No other
possibility.
This is not suited for a production set-up, where multiple servers could
have different names.
This patch fixes this problem by adding an optional "name" option to the
"add_node" command:
POST /_cluster_setup
{
"action": "add_node",
"username": "root",
"password": "******",
"host": "production-server.com",
"port": 5984,
"name": "node5"
}
This fixes: COUCHDB-3119
Member
|
LGFM |
Contributor
Author
|
Hey, any news about this? |
danielRomero
approved these changes
Nov 14, 2016
Contributor
Author
|
Please? |
Contributor
Author
|
Hey @kxepal @danielRomero, do you think this can be merged? It would be great to set-up CouchDB clusters. Thanks! |
Member
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding nodes to a cluster fails if the node names (the
nameofname@hostnamein vm.args) is different from "couchdb". The code currently infers this name from the port: "node1" if 15984, "node2" if 25984, "node3" if 35984, "couchdb" otherwise. No other possibility.This is not suited for a production set-up, where multiple servers could have different names.
This patch fixes this problem by adding an optional "name" option to the "add_node" command:
This fixes: COUCHDB-3119