Feat: to_json Infinity/-Infinity Nan values support#3875
Merged
andygrove merged 68 commits intoMay 26, 2026
Conversation
This reverts commit 768b3e9.
…support # Conflicts: # spark/src/main/scala/org/apache/comet/serde/structs.scala
Member
|
I started CI. I will review once CI has run. Thanks @kazantsev-maksim |
Contributor
Author
|
Tests using expect_fallback work incorrectly on Spark versions >= 4.0 |
andygrove
reviewed
May 19, 2026
|
|
||
| statement | ||
| INSERT INTO test_to_json VALUES (1, 'hello'), (NULL, NULL), (0, '') | ||
| INSERT INTO test_to_json VALUES (1, 'hello', cast('NaN' as float), cast('Infinity' as double)), (NULL, NULL, NULL, NULL), (0, '', 0.0, 0.0) |
Member
There was a problem hiding this comment.
Could you add -Infinity to this test
andygrove
reviewed
May 19, 2026
| .newBuilder() | ||
| .setChild(p) | ||
| .setTimezone(expr.timeZoneId.getOrElse("UTC")) | ||
| .setIgnoreNullFields(true) |
Member
There was a problem hiding this comment.
Should setIgnoreNullFields be hard-coded to true?
Member
There was a problem hiding this comment.
Also, the native code seems to ignore this field?
Member
There was a problem hiding this comment.
I think we need to respect SQLConf.get.jsonGeneratorIgnoreNullFields
…support # Conflicts: # spark/src/main/spark-4.0/org/apache/comet/shims/CometExprShim.scala # spark/src/main/spark-4.1/org/apache/comet/shims/CometExprShim.scala # spark/src/main/spark-4.2/org/apache/comet/shims/CometExprShim.scala
Contributor
Author
|
@andygrove I addressed the feedback. Could you take another look when you have time? |
andygrove
approved these changes
May 25, 2026
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM pending CI. Thanks for persevering with this @kazantsev-maksim
Contributor
Author
|
Thanks for the review @andygrove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3016
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Tested with existing unit tests