feat: Implement TimeType support - Infrastructure - shuffle#4398
Open
YutaLin wants to merge 3 commits into
Open
feat: Implement TimeType support - Infrastructure - shuffle#4398YutaLin wants to merge 3 commits into
YutaLin wants to merge 3 commits into
Conversation
Contributor
Author
|
Hi @parthchandra |
| }; | ||
| } | ||
|
|
||
| match data_type { |
Contributor
There was a problem hiding this comment.
I think you may need to add a match arm for DataType::Time64(TimeUnit::Nanosecond) here
| SELECT /*+ REPARTITION(3) */ named_struct('t', make_time(hours, minutes, secs)) AS s FROM test_time_shuffle | ||
|
|
||
| query | ||
| SELECT /*+ REPARTITION(3) */ array(make_time(hours, minutes, secs)) AS arr FROM test_time_shuffle |
Contributor
There was a problem hiding this comment.
Could you add a test case for map/list
SELECT /*+ REPARTITION(3) */ map(make_time(hours, minutes, secs), hours) AS m FROM test_time_shuffle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4396.
Rationale for this change
Support shuffle for TimeType, include native and JVM columnar
What changes are included in this PR?
CometShuffleExchangeExec.scala, so the planner will offload a shuffle carrying a TimeType column instead of fallbackhash_funcs/utils.rsspark_unsafe/row.rs,spark_unsafe/list.rsshuffle_time.sqlfor test shuffle only(no aggregate)How are these changes tested?
run sql test in spark4.1, spark4.2