chore(audit): audit any and expand tests#4436
Open
andygrove wants to merge 1 commit into
Open
Conversation
Document that `any` is a SQL alias for `BoolOr`, which Catalyst rewrites to `Max(child)` before Comet sees the plan, and add a SQL-file test covering column, literal, NULL, empty, all-NULL, group-by, and HAVING inputs for `any`, `some`, and `bool_or`. Behaviour is identical across Spark 3.4.3, 3.5.8, and 4.0.1. Scaffolded by the audit-comet-expression-autonomous skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Autonomous audit pass.
Rationale for this change
Audit of the
anyexpression against Spark 3.4.3, 3.5.8, and 4.0.1.anyis registered in Spark'sFunctionRegistryas a SQL alias ofBoolOr, which extendsRuntimeReplaceableAggregatewithreplacement = Max(child). The Catalyst analyzer rewritesany(x)(and the siblingssome(x)andbool_or(x)) tomax(x)before Comet sees the plan, so the expression is served byCometMaxon aBooleanTypecolumn.boolAggregates.scalais byte-identical across the three audited Spark versions, so no shim is required.The only finding was a test-coverage gap: the existing
test bool_and/bool_orinCometAggregateSuitecovers a single dataset of four rows with no NULLs, no empty group, no group-by, and noany/somealias.What changes are included in this PR?
anyindocs/source/contributor-guide/spark_expressions_support.mdspark/src/test/resources/sql-tests/expressions/aggregate/any.sqlcovering column, literal, NULL, empty, all-NULL, group-by, and HAVING inputs forany,some, andbool_orHow are these changes tested?
Passes locally (1 test, 0 failures).
Scaffolded by the
audit-comet-expression-autonomousskill.